Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3652 - LLM - fix undefined lottie animations #1222

Merged

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Sep 8, 2022

πŸ“ Description

Fixes undefined lottie animations for nanoS nanoSP and blue

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3652

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 8, 2022 at 1:53PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 8, 2022 at 1:53PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 8, 2022 at 1:53PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 8, 2022 at 1:53PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

πŸ¦‹ Changeset detected

Latest commit: 5df97cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LFBarreto LFBarreto marked this pull request as ready for review September 8, 2022 13:46
@github-actions github-actions bot added the mobile Has changes in LLM label Sep 8, 2022
@desirendr desirendr added this to the Ledger Live Mobile 3.8.x milestone Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

@LFBarreto

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@alalmi-ledger
Copy link
Contributor

Crash is fixed, checked on LNS and LNS+, QA ok

@alalmi-ledger alalmi-ledger merged commit 4145fe4 into release Sep 8, 2022
@alalmi-ledger alalmi-ledger deleted the bugfix/LIVE-3652-no-nanosp-lottie-animations branch September 8, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants