Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/brazilian portuguese minor issues #1239

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

ThomasLaforge
Copy link
Contributor

📝 Description

Fix missing translation keys for brazilian portugues add

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): https://ledgerhq.atlassian.net/jira/software/c/projects/LIVE/boards/463?modal=detail&selectedIssue=LIVE-3663&assignee=611511b6eb7aef0069693347

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 9, 2022 at 11:54AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 9, 2022 at 11:54AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 9, 2022 at 11:54AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 9, 2022 at 11:54AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

🦋 Changeset detected

Latest commit: 691ef32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 9, 2022
@ThomasLaforge ThomasLaforge force-pushed the bugfix/brazilian-portuguese-minor-issues branch from 54e87f5 to 0f3ba43 Compare September 9, 2022 11:48
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1239 (691ef32) into release (ebda86f) will increase coverage by 43.56%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release    #1239       +/-   ##
============================================
+ Coverage         0   43.56%   +43.56%     
============================================
  Files            0      596      +596     
  Lines            0    25337    +25337     
  Branches         0     6924     +6924     
============================================
+ Hits             0    11037    +11037     
- Misses           0    14254    +14254     
- Partials         0       46       +46     
Flag Coverage Δ
test 43.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/families/bitcoin/wallet-btc/crypto/digibyte.ts 84.21% <0.00%> (ø)
...n/src/families/filecoin/bridge/utils/serializer.ts 10.00% <0.00%> (ø)
.../ledger-live-common/src/families/tezos/exchange.ts 50.00% <0.00%> (ø)
...milies/solana/api/chain/instruction/token/types.ts 100.00% <0.00%> (ø)
...e-common/src/families/algorand/buildTransaction.ts 19.44% <0.00%> (ø)
...common/src/families/cosmos/js-createTransaction.ts 100.00% <0.00%> (ø)
...-live-common/src/families/bitcoin/serialization.ts 45.16% <0.00%> (ø)
...ger-live-common/src/families/ethereum/bridge/js.ts 59.40% <0.00%> (ø)
.../ledger-live-common/src/families/algorand/logic.ts 32.00% <0.00%> (ø)
.../ledger-live-common/src/families/tron/data.mock.ts 100.00% <0.00%> (ø)
... and 586 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

@ThomasLaforge

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected

@ThomasLaforge ThomasLaforge merged commit 2e572db into release Sep 9, 2022
@ThomasLaforge ThomasLaforge deleted the bugfix/brazilian-portuguese-minor-issues branch September 9, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants