Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAT-383 Custom image pixel polish + feature flag debug menu improvements #1243

Merged
merged 13 commits into from
Sep 15, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Sep 12, 2022

📝 Description

  • Custom image tool:

    • Changing the font of navigation headers to Inter (also applied to the entire app).
    • Removing the close button in the custom image flow.
    • Removing the “bottom drawer”-like layout appearance at the bottom of the Crop & Contrast steps.
  • Feature flag debug menu improvements

    • Added search input
    • Added "add missing flag" input
    • More compact UI (the list of FF is becoming quite long)
    • Enable/disable toggle
    • Fix overriding logic for resetting to actual remote value

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): FAT-383

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 11:01AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 13, 2022 at 11:01AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 11:01AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 11:01AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022

🦋 Changeset detected

Latest commit: 31b44df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1243 (2efe2ca) into develop (40da984) will decrease coverage by 39.03%.
The diff coverage is 86.02%.

❗ Current head 2efe2ca differs from pull request most recent head 31b44df. Consider uploading reports for the commit 31b44df to get more accurate results

@@             Coverage Diff              @@
##           develop    #1243       +/-   ##
============================================
- Coverage    85.64%   46.61%   -39.04%     
============================================
  Files           12      650      +638     
  Lines          209    28161    +27952     
  Branches        38     7488     +7450     
============================================
+ Hits           179    13126    +12947     
- Misses          30    14986    +14956     
- Partials         0       49       +49     
Flag Coverage Δ
test 46.61% <86.02%> (-39.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/env.ts 80.43% <ø> (ø)
...er-live-common/src/featureFlags/defaultFeatures.ts 100.00% <ø> (ø)
libs/ledger-live-common/src/exchange/swap/mock.ts 39.24% <50.00%> (ø)
...mmon/src/postOnboarding/PostOnboardingProvider.tsx 50.00% <50.00%> (ø)
...dgerjs/packages/hw-app-helium/src/serialization.ts 86.58% <53.84%> (ø)
...c/postOnboarding/hooks/usePostOnboardingContext.ts 75.00% <75.00%> (ø)
...s/ledger-live-common/src/postOnboarding/reducer.ts 76.00% <76.00%> (ø)
...-live-common/src/exchange/swap/getExchangeRates.ts 77.41% <100.00%> (ø)
...dger-live-common/src/exchange/swap/getProviders.ts 95.83% <100.00%> (ø)
libs/ledger-live-common/src/exchange/swap/index.ts 92.15% <100.00%> (ø)
... and 659 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 12, 2022

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Add search input
Add "add missing flag" input
More compact UI
Enable/disable toggle
Fix overriding logic for resetting to actual remote value
@github-actions github-actions bot added the translations Translation files have been touched label Sep 13, 2022
@ofreyssinet-ledger ofreyssinet-ledger changed the title FAT-383 Custom image pixel polish FAT-383 Custom image pixel polish + feature flag debug menu improvements Sep 13, 2022
@ofreyssinet-ledger ofreyssinet-ledger merged commit 3ab7ed6 into develop Sep 15, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/FAT-383-customimage-pixelpolish branch September 15, 2022 12:59
grsoares21 pushed a commit that referenced this pull request Sep 19, 2022
…nts (#1243)

* Remove close button in steps header

* Simplify appearance of BottomButtonsContainer (transparent background)

* lint

* lint

* Change header font style (use h5)

* Fix layout of cropping step

* Fix color of contrast button pill

* Rename cropAspectRatio to targetDimensions

* changeset

* remove useless `Empty` component

* lint

* Improve feature flag debug menu

Add search input
Add "add missing flag" input
More compact UI
Enable/disable toggle
Fix overriding logic for resetting to actual remote value

* Fix parsing error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants