Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/LLM handle new fully supported languages #1244

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

ThomasLaforge
Copy link
Contributor

📝 Description

Adding Japanese, Korean, Turkish and Deutcsh to fully supported languages

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): `

https://ledgerhq.atlassian.net/browse/LIVE-2993
https://ledgerhq.atlassian.net/browse/LIVE-2991`

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@ThomasLaforge ThomasLaforge requested a review from a team September 12, 2022 09:12
@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 9:12AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 12, 2022 at 9:12AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 12, 2022 at 9:12AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 12, 2022 at 9:12AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022

🦋 Changeset detected

Latest commit: 34eb4e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ThomasLaforge ThomasLaforge changed the base branch from develop to release September 12, 2022 09:12
@github-actions github-actions bot added the mobile Has changes in LLM label Sep 12, 2022
@github-actions
Copy link

github-actions bot commented Sep 12, 2022

@ThomasLaforge

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1244 (34eb4e7) into release (3195ffe) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release    #1244      +/-   ##
===========================================
- Coverage    48.03%   47.82%   -0.21%     
===========================================
  Files          674      662      -12     
  Lines        30051    29858     -193     
  Branches      7827     7793      -34     
===========================================
- Hits         14436    14281     -155     
+ Misses       15555    15517      -38     
  Partials        60       60              
Flag Coverage Δ
test 47.82% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-live-common/src/exchange/swap/getExchangeRates.ts 77.41% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/erc20.js
libs/ledgerjs/packages/cryptoassets/data/asa.js
...dgerjs/packages/cryptoassets/data/polygon-erc20.js
...dgerjs/packages/cryptoassets/data/cardanoNative.js
...s/ledgerjs/packages/cryptoassets/src/currencies.ts
libs/ledgerjs/packages/cryptoassets/data/esdt.js
libs/ledgerjs/packages/cryptoassets/data/trc10.js
libs/ledgerjs/packages/cryptoassets/src/tokens.ts
libs/ledgerjs/packages/cryptoassets/src/fiats.ts
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ThomasLaforge ThomasLaforge merged commit e5d6b43 into release Sep 12, 2022
@ThomasLaforge ThomasLaforge deleted the feat/LLM-handle-new-fully-supported-languages branch September 12, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants