Remove legacy code & assets in LLD onboarding #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 0683af8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
hedi-edelbloute
approved these changes
Sep 12, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1249 +/- ##
===========================================
- Coverage 45.93% 43.62% -2.32%
===========================================
Files 631 596 -35
Lines 27517 25353 -2164
Branches 7372 6928 -444
===========================================
- Hits 12641 11060 -1581
+ Misses 14830 14247 -583
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pierrelouis-c
approved these changes
Sep 13, 2022
|
LGTM |
ofreyssinet-ledger
deleted the
support/remove-unused-onboarding-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Just a bit of cleanup
β Context
ledger-live-desktopβ Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.