Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc gpg #1250

Merged
merged 2 commits into from
Sep 13, 2022
Merged

update doc gpg #1250

merged 2 commits into from
Sep 13, 2022

Conversation

pierrelouis-c
Copy link
Contributor

@pierrelouis-c pierrelouis-c commented Sep 12, 2022

πŸ“ Description

This PR update the GPG doc

❓ Context

  • Impacted projects: ledger-live
  • Linked resource(s):

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

You check check the result in the GPG section : https://github.com/LedgerHQ/ledger-live/blob/support/update-doc-gpg/apps/ledger-live-mobile/docs/linux_setup.md
Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 12, 2022 at 3:27PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 12, 2022 at 3:27PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 12, 2022 at 3:27PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 12, 2022 at 3:27PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022

πŸ¦‹ Changeset detected

Latest commit: ddadcb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution works fine for MacOS, I used it in the early afternoon!

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1250 (ddadcb6) into develop (772f5f8) will increase coverage by 23.83%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #1250       +/-   ##
============================================
+ Coverage    48.09%   71.92%   +23.83%     
============================================
  Files          674       14      -660     
  Lines        30085      431    -29654     
  Branches      7840       75     -7765     
============================================
- Hits         14468      310    -14158     
+ Misses       15557      116    -15441     
+ Partials        60        5       -55     
Flag Coverage Ξ”
test 71.92% <ΓΈ> (+23.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...dger-live-common/src/families/cosmos/validators.ts
...ve-common/src/families/celo/js-buildTransaction.ts
...ledger-live-common/src/families/celo/api/hubble.ts
...common/src/families/cardano/api/getTransactions.ts
...ibs/ledger-live-common/src/bridge/react/context.ts
...er-live-common/src/families/bitcoin/bridge/mock.ts
...n/src/families/osmosis/js-getFeesForTransaction.ts
...on/src/families/bitcoin/deviceTransactionConfig.ts
...-common/src/families/algorand/api/indexer.types.ts
...ommon/src/families/celo/js-getTransactionStatus.ts
... and 650 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

@pierrelouis-c

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@pierrelouis-c pierrelouis-c merged commit d4fe263 into develop Sep 13, 2022
@pierrelouis-c pierrelouis-c deleted the support/update-doc-gpg branch September 13, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants