Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(Polish): 💄 Capitalize P for Português language #1258

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 13, 2022

📝 Description

Capitalize P for Português language in settings

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3584

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Go to Settings > General > Display Language and scroll to select Português

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 2:55PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 13, 2022 at 2:55PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 2:55PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 2:55PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

🦋 Changeset detected

Latest commit: fa6f46a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Sep 13, 2022

@mcayuelas-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1258 (5944831) into develop (d9f9ba5) will increase coverage by 44.46%.
The diff coverage is n/a.

❗ Current head 5944831 differs from pull request most recent head fa6f46a. Consider uploading reports for the commit fa6f46a to get more accurate results

@@             Coverage Diff              @@
##           develop    #1258       +/-   ##
============================================
+ Coverage         0   44.46%   +44.46%     
============================================
  Files            0      629      +629     
  Lines            0    26150    +26150     
  Branches         0     7040     +7040     
============================================
+ Hits             0    11627    +11627     
- Misses           0    14469    +14469     
- Partials         0       54       +54     
Flag Coverage Δ
test 44.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...edger-live-common/src/families/stellar/exchange.ts 50.00% <0.00%> (ø)
...mmon/src/families/bitcoin/js-prepareTransaction.ts 29.41% <0.00%> (ø)
...ledger-live-common/src/families/bitcoin/account.ts 21.21% <0.00%> (ø)
...mmon/src/postOnboarding/PostOnboardingProvider.tsx 50.00% <0.00%> (ø)
libs/ledger-live-common/src/account/addAccounts.ts 8.60% <0.00%> (ø)
.../src/families/bitcoin/wallet-btc/crypto/bitcoin.ts 89.01% <0.00%> (ø)
...ve-common/src/families/celo/js-buildTransaction.ts 8.57% <0.00%> (ø)
...mon/src/families/crypto_org/js-buildTransaction.ts 18.51% <0.00%> (ø)
...mon/src/families/solana/api/chain/account/index.ts 100.00% <0.00%> (ø)
libs/ledger-live-common/src/account/pending.ts 10.25% <0.00%> (ø)
... and 619 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mcayuelas-ledger mcayuelas-ledger merged commit 8f64d09 into develop Sep 13, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the support/llm-language-polish branch September 13, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants