Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(Experimentalfeatures): Added translation for Settings and experimental features #1259

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 13, 2022

πŸ“ Description

Added translation for Settings and experimental features

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3586

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Go to Settings > Experimental features

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 13, 2022 at 10:04AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 13, 2022 at 10:04AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 10:04AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 10:04AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

πŸ¦‹ Changeset detected

Latest commit: 134ec2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1259 (5eefbd5) into develop (d4fe263) will decrease coverage by 4.42%.
The diff coverage is n/a.

❗ Current head 5eefbd5 differs from pull request most recent head 134ec2a. Consider uploading reports for the commit 134ec2a to get more accurate results

@@             Coverage Diff             @@
##           develop    #1259      +/-   ##
===========================================
- Coverage    48.22%   43.80%   -4.43%     
===========================================
  Files          687      609      -78     
  Lines        30219    25487    -4732     
  Branches      7857     6945     -912     
===========================================
- Hits         14573    11164    -3409     
+ Misses       15586    14277    -1309     
+ Partials        60       46      -14     
Flag Coverage Ξ”
test 43.80% <ΓΈ> (-4.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...ibs/ledgerjs/packages/hw-app-algorand/src/utils.ts
...edgerjs/packages/hw-app-btc/tests/newops/testtx.ts
libs/ledgerjs/packages/cryptoassets/src/tokens.ts
...s/packages/hw-app-btc/src/newops/merkelizedPsbt.ts
libs/ledgerjs/packages/cryptoassets/data/asa.js
libs/ledgerjs/packages/errors/src/helpers.ts
...s/packages/hw-app-eth/src/services/ledger/erc20.ts
.../ledgerjs/packages/hw-app-btc/src/newops/merkle.ts
libs/ledgerjs/packages/hw-app-trx/src/utils.ts
...edgerjs/packages/hw-app-btc/src/getTrustedInput.ts
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit 13960ca into develop Sep 20, 2022
@LFBarreto LFBarreto deleted the bugfix/llm-language-settings branch September 20, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants