Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3184: Add network check on add account #1270

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Conversation

henri-ly
Copy link
Contributor

@henri-ly henri-ly commented Sep 13, 2022

πŸ“ Description

Add a check of the connectivity when adding an account

❓ Context

  • Impacted projects: live-desktop
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screenshot 2022-09-13 at 16 35 33

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 13, 2022 at 2:57PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 13, 2022 at 2:57PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 2:57PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 2:57PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

πŸ¦‹ Changeset detected

Latest commit: fcfd00b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the desktop Has changes in LLD label Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1270 (7652285) into develop (3d2fa9a) will increase coverage by 1.43%.
The diff coverage is 88.23%.

❗ Current head 7652285 differs from pull request most recent head fcfd00b. Consider uploading reports for the commit fcfd00b to get more accurate results

@@             Coverage Diff             @@
##           develop    #1270      +/-   ##
===========================================
+ Coverage    45.93%   47.36%   +1.43%     
===========================================
  Files          631      661      +30     
  Lines        27517    29044    +1527     
  Branches      7372     7657     +285     
===========================================
+ Hits         12641    13758    +1117     
- Misses       14830    15236     +406     
- Partials        46       50       +4     
Flag Coverage Ξ”
test 47.36% <88.23%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...er-live-common/src/featureFlags/defaultFeatures.ts 100.00% <ΓΈ> (ΓΈ)
...mmon/src/postOnboarding/PostOnboardingProvider.tsx 50.00% <50.00%> (ΓΈ)
...c/postOnboarding/hooks/usePostOnboardingContext.ts 75.00% <75.00%> (ΓΈ)
...s/ledger-live-common/src/postOnboarding/reducer.ts 76.00% <76.00%> (ΓΈ)
...edger-live-common/src/hw/extractOnboardingState.ts 94.73% <100.00%> (+0.61%) ⬆️
...s/ledger-live-common/src/postOnboarding/actions.ts 100.00% <100.00%> (ΓΈ)
...ding/hooks/useAllPostOnboardingActionsCompleted.ts 100.00% <100.00%> (ΓΈ)
...ooks/usePostOnboardingEntryPointVisibleOnWallet.ts 100.00% <100.00%> (ΓΈ)
.../postOnboarding/hooks/usePostOnboardingHubState.ts 100.00% <100.00%> (ΓΈ)
libs/ledger-live-common/src/postOnboarding/mock.ts 100.00% <100.00%> (ΓΈ)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

@henrily-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

{currency ? <CurrencyDownStatusAlert currencies={[currency]} /> : null}
{!navigator.onLine ? (
<div>
<ErrorBanner error={new NetworkDown()} />
Copy link
Member

@hedi-edelbloute hedi-edelbloute Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it matters in React but my Angular spidey sense would put it outside the template, just before the return in the js part.

In angular this could trigger more changeDetection events and more objects created

I would create a networkDownError const and use it there

@desirendr
Copy link
Contributor

@henrily-ledger merging this as it's been validated by @mdeidda-ledger and reviewed ! πŸš€

@desirendr desirendr merged commit b0e566f into develop Sep 20, 2022
@desirendr desirendr deleted the bugfix/LIVE-3184 branch September 20, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants