-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVE-3184: Add network check on add account #1270
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: fcfd00b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #1270 +/- ##
===========================================
+ Coverage 45.93% 47.36% +1.43%
===========================================
Files 631 661 +30
Lines 27517 29044 +1527
Branches 7372 7657 +285
===========================================
+ Hits 12641 13758 +1117
- Misses 14830 15236 +406
- Partials 46 50 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@henrily-ledger Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
{currency ? <CurrencyDownStatusAlert currencies={[currency]} /> : null} | ||
{!navigator.onLine ? ( | ||
<div> | ||
<ErrorBanner error={new NetworkDown()} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it matters in React but my Angular spidey sense would put it outside the template, just before the return in the js part.
In angular this could trigger more changeDetection events and more objects created
I would create a networkDownError const and use it there
@henrily-ledger merging this as it's been validated by @mdeidda-ledger and reviewed ! π |
π Description
Add a check of the connectivity when adding an account
β Context
live-desktop
β Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.