Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(Translation): Add i18nKey missing in Settings for Experimental Countervalues API #1271

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 13, 2022

πŸ“ Description

Add i18nKey missing in Settings for Experimental Countervalues API

❓ Context

  • Impacted projects: live-desktop
  • Linked resource(s): LIVE-3580

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

On LLD > Settings > Experimental features

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 13, 2022 at 3:13PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 13, 2022 at 3:13PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 3:13PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 13, 2022 at 3:13PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

πŸ¦‹ Changeset detected

Latest commit: e99e176

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD translations Translation files have been touched labels Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1271 (e99e176) into develop (e11d177) will decrease coverage by 25.54%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #1271       +/-   ##
============================================
- Coverage    72.14%   46.60%   -25.55%     
============================================
  Files           77      654      +577     
  Lines         4675    28271    +23596     
  Branches       905     7342     +6437     
============================================
+ Hits          3373    13176     +9803     
- Misses        1291    15041    +13750     
- Partials        11       54       +43     
Flag Coverage Ξ”
test 46.60% <ΓΈ> (-25.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...ibs/ledgerjs/packages/hw-app-algorand/src/utils.ts
libs/ledgerjs/packages/hw-app-tezos/src/Tezos.ts
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts
...s/ledgerjs/packages/cryptoassets/src/currencies.ts
...ckages/hw-app-eth/src/services/ledger/contracts.ts
libs/ledgerjs/packages/cryptoassets/src/tokens.ts
libs/ledgerjs/packages/hw-app-trx/src/Trx.ts
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts
.../ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts
libs/ledgerjs/packages/cryptoassets/data/erc20.js
... and 633 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit 3061dbd into develop Sep 15, 2022
@LFBarreto LFBarreto deleted the bugfix/lld-i18n-translation-missing branch September 15, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants