Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(UI): Update text and ui for Add Account modal #1277

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 14, 2022

📝 Description

Update text and ui for Add Account modal

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3714

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Before
Screenshot 2022-09-14 at 15 42 35

After
Screenshot 2022-09-14 at 16 02 54

🚀 Expectations to reach

Go to Accounts > Add Account

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 14, 2022 at 2:09PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 14, 2022 at 2:09PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 14, 2022 at 2:09PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 14, 2022 at 2:09PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

🦋 Changeset detected

Latest commit: 2d2b134

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 0.00% // Head: 43.74% // Increases project coverage by +43.74% 🎉

Coverage data is based on head (fa647f7) compared to base (36f55b4).
Patch has no changes to coverable lines.

❗ Current head fa647f7 differs from pull request most recent head 2d2b134. Consider uploading reports for the commit 2d2b134 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1277       +/-   ##
============================================
+ Coverage         0   43.74%   +43.74%     
============================================
  Files            0      610      +610     
  Lines            0    25571    +25571     
  Branches         0     6956     +6956     
============================================
+ Hits             0    11185    +11185     
- Misses           0    14340    +14340     
- Partials         0       46       +46     
Flag Coverage Δ
test 43.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-live-common/src/currencies/sanitizeValueString.ts 100.00% <0.00%> (ø)
libs/ledger-live-common/src/families/tron/utils.ts 11.76% <0.00%> (ø)
...live-common/src/families/algorand/serialization.ts 33.33% <0.00%> (ø)
...-live-common/src/families/bitcoin/serialization.ts 45.16% <0.00%> (ø)
...s/ledger-live-common/src/families/cardano/types.ts 100.00% <0.00%> (ø)
...-common/src/families/celo/js-prepareTransaction.ts 30.00% <0.00%> (ø)
...n/src/exchange/swap/hooks/usePickDefaultAccount.ts 100.00% <0.00%> (ø)
...on/src/families/filecoin/bridge/utils/addresses.ts 23.43% <0.00%> (ø)
...ledger-live-common/src/hw/signTransaction/index.ts 62.50% <0.00%> (ø)
libs/ledger-live-common/src/apps/formatting.ts 100.00% <0.00%> (ø)
... and 600 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

@mcayuelas-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@mcayuelas-ledger mcayuelas-ledger merged commit 11d5917 into develop Sep 19, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the support/llm-update-drawer branch September 19, 2022 08:42
grsoares21 pushed a commit that referenced this pull request Sep 19, 2022
* support(UI): Update text and ui for Add Account modal

* 💄 Add margin bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants