FAT-100: Adaptations on the Manager for FTS #1279
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a431563 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
common
Codecov ReportBase: 43.57% // Head: 43.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1279 +/- ##
===========================================
+ Coverage 43.57% 43.63% +0.05%
===========================================
Files 610 619 +9
Lines 25490 26280 +790
Branches 6982 7117 +135
===========================================
+ Hits 11107 11466 +359
- Misses 13255 14761 +1506
+ Partials 1128 53 -1075
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
thomasrogerlux
force-pushed
the
feat/FAT-82-LLM-new-onboarding-flow
branch
from
ea557b9
to
3fdc645
Compare
github-actions
bot
added
cli
ledgerjs
grsoares21
force-pushed
the
feat/FAT-100
branch
from
3990a85
to
7340e9b
Compare
| import { useNavigation } from "@react-navigation/native"; | ||
| import { Text, Flex, Icons, BottomDrawer } from "@ledgerhq/native-ui"; | ||
| import { Device } from "@ledgerhq/live-common/lib/hw/actions/types"; | ||
| import { useBleDevicesScanning } from "@ledgerhq/live-common/lib/ble/hooks/useBleDevicesScanning"; |
There was a problem hiding this comment.
🚨 2 imports with lib 🏃
There was a problem hiding this comment.
Good catch! fixed
| import React, { useCallback, useMemo } from "react"; | ||
| import { Trans } from "react-i18next"; | ||
| import { useDispatch } from "react-redux"; | ||
| import { Device } from "@ledgerhq/live-common/lib/hw/actions/types"; |
There was a problem hiding this comment.
Good catch! fixed
apps/cli/src/commands-index.ts
Outdated
| @@ -102,4 +102,4 @@ export default { | |||
| user, | |||
| version, | |||
| walletconnect | |||
| }; | |||
| } as any; | |||
There was a problem hiding this comment.
is this one really a problem? it's requiring a type annotation due to references in the lib. But it's the CLI, will we enforce this rule even in the CLI?
| ) | ||
| ); | ||
| }, | ||
| } as any; |
| @@ -101,13 +103,16 @@ registerTransportModule({ | |||
| id.startsWith("usb|") | |||
| ? Promise.resolve() // nothing to do | |||
| : null, | |||
| discovery: Observable.create(o => HIDTransport.listen(o)).pipe( | |||
| discovery: new Observable<DescriptorEvent<any>>(o => | |||
There was a problem hiding this comment.
using unknown as this type is not very revelant for the context here
| } = this.props; | ||
| const onHideMenu = () => setShowMenu(false); | ||
|
|
||
| const onSelect = (result: any) => { |
There was a problem hiding this comment.
Using unknown instead as the result type from a device action is very "unknown"
| if (!interactive) return events; | ||
| return events | ||
| .pipe( | ||
| rxScan((acc: any[], value) => { |
There was a problem hiding this comment.
Typed it correctly
📝 Description
This PR rebuilds the device selection screen, with pointers to the new onboarding and new BLE pairing flows.
It uses custom icons for the manager tab according to the last seen device.
It adds a new button on the manager for FTS device to trigger the custom image flow.
It revamps the "not onboarded" device action error with new copy, illustration and a button directing to the right onboarding flow according to the device.
❓ Context
ledger-live-mobile✅ Checklist
📸 Demo
demo-new-manager-fts.mov
🚀 Expectations to reach