Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(SendNFT): Update error message when trying to send NFTs with LNS #1285

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 15, 2022

πŸ“ Description

Update error message when trying to send NFTs with LNS

❓ Context

  • Impacted projects: live-desktop live-mobile
  • Linked resource(s): LIVE-2725

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Try send NFT with Nano S or S Plus

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 15, 2022 at 9:11AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 15, 2022 at 9:11AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 15, 2022 at 9:11AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 15, 2022 at 9:11AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

πŸ¦‹ Changeset detected

Latest commit: 368f26a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
ledger-live-desktop Patch
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Sep 15, 2022
@github-actions
Copy link

github-actions bot commented Sep 15, 2022

@mcayuelas-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected

@LFBarreto LFBarreto merged commit 957351a into develop Sep 20, 2022
@LFBarreto LFBarreto deleted the support/wording-send-nft-lns branch September 20, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants