Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM custom image fixes #1297

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Sep 16, 2022

📝 Description

Fixes for the custom image tool:

  • Back button behaviour in the first step: If the image is coming from the phone gallery, pressing the back button should reopen the gallery
  • Prevent choosing another contrast if current contrast is loading
  • Implement dithering → quality improvement of image, avoiding color banding
  • Implement new ordering of pixels
    • in raw data result
    • in raw data result verifier (the last screen that reconstructs the image from the raw data)

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): FAT-395 FAT-406

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@ofreyssinet-ledger ofreyssinet-ledger self-assigned this Sep 16, 2022
@vercel
Copy link

vercel bot commented Sep 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 0:08AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 16, 2022 at 0:08AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 16, 2022 at 0:08AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 16, 2022 at 0:08AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2022

🦋 Changeset detected

Latest commit: 3f1f0fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofreyssinet-ledger ofreyssinet-ledger merged commit e315e55 into develop Sep 20, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/llm-custom-image-fixes branch September 20, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants