Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(UI): UI issue on Sync modal #1308

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 19, 2022

πŸ“ Description

UI issue on Sync modal

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3650

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Before
View recent photos
After
https://user-images.githubusercontent.com/112866305/191022822-3abe93e3-3c47-4c07-94ef-35568429a61c.mp4

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 20, 2022 at 2:05PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 20, 2022 at 2:05PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 20, 2022 at 2:05PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 20, 2022 at 2:05PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

πŸ¦‹ Changeset detected

Latest commit: 09497a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 19, 2022
@github-actions
Copy link

github-actions bot commented Sep 19, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@LFBarreto LFBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix the lint issues
pnpm mobile lint

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 45.54% // Head: 43.88% // Decreases project coverage by -1.66% ⚠️

Coverage data is based on head (0e756a4) compared to base (df76dd2).
Patch coverage: 10.12% of modified lines in pull request are covered.

❗ Current head 0e756a4 differs from pull request most recent head 09497a6. Consider uploading reports for the commit 09497a6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1308      +/-   ##
===========================================
- Coverage    45.54%   43.88%   -1.67%     
===========================================
  Files          631      610      -21     
  Lines        26620    25520    -1100     
  Branches      7183     6953     -230     
===========================================
- Hits         12125    11200     -925     
+ Misses       14448    14274     -174     
+ Partials        47       46       -1     
Flag Coverage Ξ”
test 43.88% <10.12%> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/apps/support.ts 31.81% <ΓΈ> (ΓΈ)
libs/ledger-live-common/src/bot/formatters.ts 21.11% <0.00%> (-0.99%) ⬇️
...ive-common/src/families/cosmos/js-signOperation.ts 16.25% <0.00%> (-0.42%) ⬇️
...e-common/src/families/cosmos/js-synchronisation.ts 10.61% <3.22%> (+1.61%) ⬆️
.../ledger-live-common/src/families/cosmos/helpers.ts 100.00% <100.00%> (ΓΈ)
...kages/hw-app-eth/src/services/ledger/loadConfig.ts
...s/packages/hw-app-eth/src/services/ledger/erc20.ts
libs/ledgerjs/packages/cryptoassets/data/trc20.js
...dgerjs/packages/cryptoassets/data/polygon-erc20.js
libs/ledgerjs/packages/hw-app-eth/src/utils.ts
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@LFBarreto LFBarreto merged commit 5ff3a44 into develop Oct 5, 2022
@LFBarreto LFBarreto deleted the bugfix/llm-sync-modal branch October 5, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants