-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(UI): UI issue on Sync modal #1308
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 09497a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you fix the lint issues
pnpm mobile lint
Codecov ReportBase: 45.54% // Head: 43.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1308 +/- ##
===========================================
- Coverage 45.54% 43.88% -1.67%
===========================================
Files 631 610 -21
Lines 26620 25520 -1100
Branches 7183 6953 -230
===========================================
- Hits 12125 11200 -925
+ Misses 14448 14274 -174
+ Partials 47 46 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
π Description
UI issue on Sync modal
β Context
live-mobile
β Checklist
πΈ Demo
Before
After
https://user-images.githubusercontent.com/112866305/191022822-3abe93e3-3c47-4c07-94ef-35568429a61c.mp4
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.