Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(Testnet): LLM - Add account flow: Testnet currencies shouldn't be available by default #1320

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 20, 2022

πŸ“ Description

Add account flow: Testnet currencies shouldn't be available by default

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-1980

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen_Recording_20220920-153059_LL.DEV.mp4

πŸš€ Expectations to reach

  • Settings -> Experimental features β†’ Developper Mode = OFF
  • Go to add account flow
  • Search for β€œTestnet”
    Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 18, 2022 at 0:59AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 18, 2022 at 0:59AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 18, 2022 at 0:59AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 18, 2022 at 0:59AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

πŸ¦‹ Changeset detected

Latest commit: 420b19e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Sep 20, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 43.09% // Head: 43.09% // No change to project coverage πŸ‘

Coverage data is based on head (b07a544) compared to base (b07a544).
Patch has no changes to coverable lines.

❗ Current head b07a544 differs from pull request most recent head 420b19e. Consider uploading reports for the commit 420b19e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1320   +/-   ##
========================================
  Coverage    43.09%   43.09%           
========================================
  Files          610      610           
  Lines        25514    25514           
  Branches      6987     6987           
========================================
  Hits         10995    10995           
  Misses       14469    14469           
  Partials        50       50           
Flag Coverage Ξ”
test 43.09% <0.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 13, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@mcayuelas-ledger mcayuelas-ledger changed the title bugfix(Testnet): Add account flow: Testnet currencies shouldn't be available by default bugfix(Testnet): LLM - Add account flow: Testnet currencies shouldn't be available by default Oct 13, 2022
@mcayuelas-ledger mcayuelas-ledger merged commit bc892dc into develop Oct 18, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/llm-testnet-currencies branch October 18, 2022 14:41
nparigi-ledger pushed a commit that referenced this pull request Oct 27, 2022
… be available by default (#1320)

* bugfix(Testnet): Add account flow: Testnet currencies shouldn't be available by default

* Add changelog

* 🚨 Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants