Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/live 3251 ratings and notifs modals conflicts fixed #1322

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Sep 20, 2022

📝 Description

Fixed a bug causing a freeze on ios when the ratings modal opened at the same time as the notifications one
Factorised some code regarding the navigation listener for the ratings and the push notifications
Fixed a navigation issue preventing the notifications modal to appear on the reborn account screens

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 8:57AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 11, 2022 at 8:57AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 11, 2022 at 8:57AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 11, 2022 at 8:57AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: ee2c169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 43.64% // Head: 75.40% // Increases project coverage by +31.76% 🎉

Coverage data is based on head (ee2c169) compared to base (adee78e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1322       +/-   ##
============================================
+ Coverage    43.64%   75.40%   +31.76%     
============================================
  Files          610       59      -551     
  Lines        25543     3383    -22160     
  Branches      6971      701     -6270     
============================================
- Hits         11148     2551     -8597     
+ Misses       14346      831    -13515     
+ Partials        49        1       -48     
Flag Coverage Δ
test 75.40% <ø> (+31.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ibs/ledger-live-common/src/families/cosmos/mock.ts
.../src/families/bitcoin/wallet-btc/crypto/bitcoin.ts
libs/ledger-live-common/src/apps/react.ts
...edger-live-common/src/families/bitcoin/networks.ts
...er-live-common/src/families/hedera/js-broadcast.ts
...s/ledger-live-common/src/families/evm/bridge/js.ts
...common/src/families/bitcoin/js-buildTransaction.ts
...ve-common/src/families/evm/getTransactionStatus.ts
libs/ledger-live-common/src/apps/formatting.ts
...ledger-live-common/src/hw/signTransaction/index.ts
... and 659 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 20, 2022

@cgrellard-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

@cgrellard-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@cgrellard-ledger cgrellard-ledger merged commit 8438e77 into develop Oct 13, 2022
@cgrellard-ledger cgrellard-ledger deleted the bugfix/LIVE-3251-ratings-and-notifs-modals-conflicts-fixed branch October 13, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants