Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/LIVE-3804 Bump hermes-engine dependency to 0.11.0 #1328

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

juan-cortes
Copy link
Contributor

πŸ“ Description

Bumps a library to fix some reported vulnerabilities by dependabot

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-3804

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸš€ Expectations to reach

In theory no breaking changes should happen, anything breaking should be caught in the non regression phase.

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 21, 2022 at 8:34AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 21, 2022 at 8:34AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 21, 2022 at 8:34AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 21, 2022 at 8:34AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

πŸ¦‹ Changeset detected

Latest commit: 877dc46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 21, 2022
@valpinkman
Copy link
Member

Good for me. QA might be needed tho ?

Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Œ

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 46.53% // Head: 48.11% // Increases project coverage by +1.58% πŸŽ‰

Coverage data is based on head (877dc46) compared to base (fb0128b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1328      +/-   ##
===========================================
+ Coverage    46.53%   48.11%   +1.58%     
===========================================
  Files          665      688      +23     
  Lines        28394    30303    +1909     
  Branches      7518     7891     +373     
===========================================
+ Hits         13213    14581    +1368     
- Misses       15125    15660     +535     
- Partials        56       62       +6     
Flag Coverage Ξ”
test 48.11% <ΓΈ> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/hw-app-tezos/src/Tezos.ts 11.34% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-trx/src/utils.ts 61.40% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-str/src/utils.ts 91.37% <0.00%> (ΓΈ)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ΓΈ)
...s/packages/hw-app-eth/src/services/ledger/index.ts 81.96% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts 89.28% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ΓΈ)
...js/packages/hw-app-eth/src/services/ledger/nfts.ts 12.50% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-eth/src/errors.ts 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts 78.13% <0.00%> (ΓΈ)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

@juan-cortes

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@chabroA chabroA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

@alalmi-ledger
Copy link
Contributor

QA OK, checked on LLM iOS and Android

@juan-cortes juan-cortes merged commit 521582f into develop Sep 25, 2022
@juan-cortes juan-cortes deleted the feat/LIVE-3804 branch September 25, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants