Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(UI-Improvment): Accents are cropped on the Onboarding carousel #1329

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 21, 2022

πŸ“ Description

Accents were cropped on the Onboarding carousel

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-2675

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Do Onboarding Flow in French

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 21, 2022 at 9:10AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 21, 2022 at 9:10AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 21, 2022 at 9:10AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 21, 2022 at 9:10AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

πŸ¦‹ Changeset detected

Latest commit: 66158fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 46.53% // Head: 72.02% // Increases project coverage by +25.48% πŸŽ‰

Coverage data is based on head (84891aa) compared to base (fb0128b).
Patch has no changes to coverable lines.

❗ Current head 84891aa differs from pull request most recent head 66158fa. Consider uploading reports for the commit 66158fa to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1329       +/-   ##
============================================
+ Coverage    46.53%   72.02%   +25.48%     
============================================
  Files          665       78      -587     
  Lines        28394     4779    -23615     
  Branches      7518      934     -6584     
============================================
- Hits         13213     3442     -9771     
+ Misses       15125     1323    -13802     
+ Partials        56       14       -42     
Flag Coverage Ξ”
test 72.02% <ΓΈ> (+25.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/bridge/jsHelpers.ts
...s/ledger-live-common/src/families/evm/bridge/js.ts
...-common/src/families/hedera/hw-app-hedera/index.ts
...rc/families/crypto_org/js-getFeesForTransaction.ts
...live-common/src/families/ethereum/signOperation.ts
...on/src/families/bitcoin/js-getTransactionStatus.ts
libs/ledger-live-common/src/bridge/mockHelpers.ts
...on/src/notifications/AnnouncementProvider/logic.ts
...edger-live-common/src/families/solana/api/index.ts
...mmon/src/families/polkadot/js-createTransaction.ts
... and 623 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit 227d28a into develop Oct 5, 2022
@LFBarreto LFBarreto deleted the support/llm-cropped-accent branch October 5, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants