Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(UI): LLM - iOS/Android - Market General Layout polish #1335

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 21, 2022

📝 Description

LLM - iOS/Android - Market General Layout polish

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-2096

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screen_Recording_20220921-174201_LL.DEV.mp4

🚀 Expectations to reach

Go To Market Page
Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 7:49AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:49AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:49AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:49AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

🦋 Changeset detected

Latest commit: ce14a6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 21, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022

@mcayuelas-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 43.01% // Head: 47.23% // Increases project coverage by +4.22% 🎉

Coverage data is based on head (ce14a6b) compared to base (eee8334).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1335      +/-   ##
===========================================
+ Coverage    43.01%   47.23%   +4.22%     
===========================================
  Files          609      670      +61     
  Lines        25472    29668    +4196     
  Branches      6978     7813     +835     
===========================================
+ Hits         10957    14014    +3057     
- Misses       13382    15598    +2216     
+ Partials      1133       56    -1077     
Flag Coverage Δ
test 47.23% <ø> (+4.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ø)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ø)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ø)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ø)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ø)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ø)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ø)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ø)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ø)
libs/ledger-live-common/src/apps/logic.ts 89.71% <0.00%> (ø)
... and 298 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

@mcayuelas-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@mcayuelas-ledger mcayuelas-ledger merged commit c356580 into develop Oct 13, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the support/llm-market-polishing branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants