Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: LLD big lag when ending the onboarding #1336

Merged
merged 14 commits into from
Sep 22, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Sep 21, 2022

πŸ“ Description

Add a loading state in the "continue" button at the end of the onboarding to improve the UX in case of a lag.

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): LIVE-3810

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen.Recording.2022-09-21.at.20.03.04.mov

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team September 21, 2022 16:04
@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 22, 2022 at 1:53PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 22, 2022 at 1:53PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 22, 2022 at 1:53PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 22, 2022 at 1:53PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

πŸ¦‹ Changeset detected

Latest commit: f208b67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools ui Has changes in the design system library labels Sep 21, 2022
@ofreyssinet-ledger ofreyssinet-ledger changed the title Bugfix/live 3810 onboarding end delay Bugfix: LLD big lag when ending the onboarding Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 43.63% // Head: 73.26% // Increases project coverage by +29.62% πŸŽ‰

Coverage data is based on head (ec85657) compared to base (837d872).
Patch has no changes to coverable lines.

❗ Current head ec85657 differs from pull request most recent head f208b67. Consider uploading reports for the commit f208b67 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           release    #1336       +/-   ##
============================================
+ Coverage    43.63%   73.26%   +29.62%     
============================================
  Files          610       56      -554     
  Lines        25523     3935    -21588     
  Branches      6957      807     -6150     
============================================
- Hits         11138     2883     -8255     
+ Misses       14337     1046    -13291     
+ Partials        48        6       -42     
Flag Coverage Ξ”
test 73.26% <ΓΈ> (+29.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...on/src/families/filecoin/bridge/utils/addresses.ts
...edger-live-common/src/families/cosmos/bridge/js.ts
...ger-live-common/src/families/tron/hw-getAddress.ts
...er-live-common/src/families/tezos/hw-getAddress.ts
...-live-common/src/families/tezos/synchronisation.ts
...mmon/src/families/tezos/deviceTransactionConfig.ts
...edger-live-common/src/families/celo/hw-app-celo.ts
...ger-live-common/src/exchange/swap/postSwapState.ts
libs/ledger-live-common/src/observable.ts
...ledger-live-common/src/families/tezos/bridge/js.ts
... and 656 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@ofreyssinet-ledger ofreyssinet-ledger marked this pull request as draft September 21, 2022 16:29
@github-actions
Copy link

github-actions bot commented Sep 21, 2022

@ofreyssinet-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions github-actions bot removed ui Has changes in the design system library cli tools Has changes in tools ledgerjs Has changes in the ledgerjs open source libs common Has changes in live-common labels Sep 21, 2022
@ofreyssinet-ledger ofreyssinet-ledger marked this pull request as ready for review September 21, 2022 18:03
@ofreyssinet-ledger
Copy link
Contributor Author

/generate-screenshots

@ofreyssinet-ledger
Copy link
Contributor Author

ofreyssinet-ledger commented Sep 22, 2022

/generate-screenshots

edit: job is here (previously failed) https://github.com/LedgerHQ/ledger-live/actions/runs/3104929261

@pierrelouis-c
Copy link
Contributor

/generate-screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants