-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: LLD big lag when ending the onboarding #1336
Bugfix: LLD big lag when ending the onboarding #1336
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: f208b67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 43.63% // Head: 73.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release #1336 +/- ##
============================================
+ Coverage 43.63% 73.26% +29.62%
============================================
Files 610 56 -554
Lines 25523 3935 -21588
Branches 6957 807 -6150
============================================
- Hits 11138 2883 -8255
+ Misses 14337 1046 -13291
+ Partials 48 6 -42
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
/generate-screenshots |
/generate-screenshots edit: job is here (previously failed) https://github.com/LedgerHQ/ledger-live/actions/runs/3104929261 |
/generate-screenshots |
π Description
Add a loading state in the "continue" button at the end of the onboarding to improve the UX in case of a lag.
β Context
ledger-live-desktop
β Checklist
πΈ Demo
Screen.Recording.2022-09-21.at.20.03.04.mov
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.