Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/remove english from pushed languages #1342

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

ThomasLaforge
Copy link
Contributor

  • 🚀 entering LLD prerelease mode
  • fix: mixed changesets
  • fix: mixed changesets
  • fix: mixed changesets
  • 🚀 release prerelease [LLD(2.48.0-next.0)]
  • [REVERT] Bugfix: Revert force 1.9.20 ethereum app ([REVERT] Bugfix: Revert force 1.9.20 ethereum app #1330)
  • 🚀 release prerelease [LLD(2.48.0-next.1)]
  • remove english from pushed language
  • changeset

📝 Description

fix os language available modal appearing when language is in english

❓ Context

  • Impacted projects: LLD
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 8:35AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 22, 2022 at 8:35AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 22, 2022 at 8:35AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 22, 2022 at 8:35AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: dacdf1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 43.63% // Head: 72.02% // Increases project coverage by +28.38% 🎉

Coverage data is based on head (dacdf1b) compared to base (837d872).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           release    #1342       +/-   ##
============================================
+ Coverage    43.63%   72.02%   +28.38%     
============================================
  Files          610       78      -532     
  Lines        25523     4779    -20744     
  Branches      6957      934     -6023     
============================================
- Hits         11138     3442     -7696     
+ Misses       14337     1323    -13014     
+ Partials        48       14       -34     
Flag Coverage Δ
test 72.02% <ø> (+28.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...live-common/src/families/algorand/hw-getAddress.ts
...dger-live-common/src/exchange/swap/getProviders.ts
...-common/src/families/osmosis/js-synchronization.ts
...ve-common/src/families/polkadot/platformAdapter.ts
libs/ledger-live-common/src/csvExport.ts
...mmon/src/exchange/swap/hooks/useUpdateMaxAmount.ts
libs/ledger-live-common/src/crypto/index.ts
...edger-live-common/src/generated/platformAdapter.ts
libs/ledger-live-common/src/nft/nftId.ts
...er-live-common/src/hw/getOnboardingStatePolling.ts
... and 678 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

@ThomasLaforge

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ThomasLaforge ThomasLaforge merged commit 2e971a9 into release Sep 22, 2022
@ThomasLaforge ThomasLaforge deleted the bugfix/remove-english-from-pushed-languages branch September 22, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants