Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(Disclaimer):Error message when trying to send a NFT from LNS is wrong #1348

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 22, 2022

πŸ“ Description

Error message when trying to send a NFT from LNS is wrong

❓ Context

  • Impacted projects: live-desktop live-mobile
  • Linked resource(s): LIVE-3845

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 22, 2022 at 3:02PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 22, 2022 at 3:02PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 22, 2022 at 3:02PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 22, 2022 at 3:02PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

πŸ¦‹ Changeset detected

Latest commit: 41bda3d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Sep 22, 2022
@LFBarreto LFBarreto changed the base branch from develop to release September 22, 2022 14:51
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 45.46% // Head: 43.63% // Decreases project coverage by -1.82% ⚠️

Coverage data is based on head (41bda3d) compared to base (fb9230a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1348      +/-   ##
===========================================
- Coverage    45.46%   43.63%   -1.83%     
===========================================
  Files          630      610      -20     
  Lines        27041    25523    -1518     
  Branches      7248     6957     -291     
===========================================
- Hits         12293    11137    -1156     
+ Misses       14696    14338     -358     
+ Partials        52       48       -4     
Flag Coverage Ξ”
test 43.63% <ΓΈ> (-1.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/hw-app-tezos/src/Tezos.ts
libs/ledgerjs/packages/hw-app-trx/src/utils.ts
libs/ledgerjs/packages/hw-app-trx/src/Trx.ts
...s/hw-transport-mocker/src/openTransportReplayer.ts
...ckages/hw-app-eth/src/services/ledger/contracts.ts
...kages/hw-app-eth/src/services/ledger/loadConfig.ts
...js/packages/hw-app-eth/src/modules/EIP712/index.ts
libs/ledgerjs/packages/hw-app-eth/src/errors.ts
libs/ledgerjs/packages/hw-app-eth/src/utils.ts
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit ec38e18 into release Sep 23, 2022
@LFBarreto LFBarreto deleted the support/lld-llm-wrong-message-send-nft branch September 23, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants