LLD FAT-421 - Custom lock screen full flow

[ofreyssinet-ledger]

📝 Description

Details in the associated Jira tickets.

screenshots test report: (I'm linking this here bc it's getting drowned in the nb of msgs on this PR)
#1352 (comment)

❓ Context

• Impacted projects: ledger-live-desktop ledger-live-mobile live-common
• Linked resource(s): FAT-421

✅ Checklist

• Test coverage
• Atomic delivery
• No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	❌ Failed (Inspect)		Oct 27, 2022 at 3:22PM (UTC)

3 Ignored Deployments

Name	Status	Preview	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)		Oct 27, 2022 at 3:22PM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)		Oct 27, 2022 at 3:22PM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)		Oct 27, 2022 at 3:22PM (UTC)

[changeset-bot]

🦋 Changeset detected

Latest commit: 8ee7f55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@ledgerhq/react-ui	Patch
live-mobile	Patch
@ledgerhq/live-common	Patch
ledger-live-desktop	Patch
@ledgerhq/live-cli	Patch
live-common-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ofreyssinet-ledger]

in this file I did 3 things:

• renaming of slightly confusing names
• cleanup of useless logic (the const v3SelectedPalettes = ... and palettesAny: any = palettes)
• adding v2Palettes to colors because in one case (ContrastChoice component) we need to access a v2 background color in a v3 component which therefore cannot access that color (because style provider context etc.)

[codecov]

Codecov Report

Base: 0.00% // Head: 47.94% // Increases project coverage by +47.94% 🎉

Coverage data is based on head (e2fecdb) compared to base (6de53ce).
Patch has no changes to coverable lines.

❗ Current head e2fecdb differs from pull request most recent head 8ee7f55. Consider uploading reports for the commit 8ee7f55 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #1352       +/-   ##
============================================
+ Coverage         0   47.94%   +47.94%     
============================================
  Files            0      691      +691     
  Lines            0    30445    +30445     
  Branches         0     7977     +7977     
============================================
+ Hits             0    14597    +14597     
- Misses           0    14636    +14636     
- Partials         0     1212     +1212     

Flag	Coverage Δ
test	47.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...kages/hw-app-eth/src/services/ledger/loadConfig.ts	100.00% <0.00%> (ø)
...bs/ledger-live-common/src/families/solana/logic.ts	24.61% <0.00%> (ø)
libs/ledger-live-common/src/apps/react.ts	85.00% <0.00%> (ø)
...ages/hw-app-eth/src/modules/EIP712/EIP712.utils.ts	93.75% <0.00%> (ø)
...ive-common/src/families/ethereum/modules/erc721.ts	26.22% <0.00%> (ø)
...-live-common/src/families/ethereum/modules/send.ts	22.47% <0.00%> (ø)
...live-common/src/families/algorand/hw-getAddress.ts	50.00% <0.00%> (ø)
...ilies/solana/api/chain/instruction/system/index.ts	36.36% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-trx/src/utils.ts	61.40% <0.00%> (ø)
...-live-common/src/families/stellar/hw-getAddress.ts	50.00% <0.00%> (ø)
... and 681 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

@ofreyssinet-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual	Diff	Expected
custom-image-adjust-4-rotate-once-actual	custom-image-adjust-4-rotate-once-diff	custom-image-adjust-4-rotate-once-expected
v3-onboarding-complete-actual	v3-onboarding-complete-diff	v3-onboarding-complete-expected
v3-onboarding-complete-actual	v3-onboarding-complete-diff	v3-onboarding-complete-expected

windows

Actual	Diff	Expected
discover-actual	discover-diff	discover-expected

[ofreyssinet-ledger]

/generate-screenshots

[ofreyssinet-ledger]

/generate-screenshots

[github-actions]

@ofreyssinet-ledger

Generating screenshots: workflow ended:

Jobs status:
✅ - generate-screenshots (ubuntu-latest)
✅ - generate-screenshots (windows-latest)
✅ - generate-screenshots-mac-internal

[alexandremgo]

🔥