Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(UI-Improvment) : LLM- Sync from Desktop #1359

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 23, 2022

πŸ“ Description

LLM- Sync from Desktop UI Improvment

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3842

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen_Recording_20220923-110952_LL.DEV.mp4

πŸš€ Expectations to reach

Do Onboarding > Sync from Desktop

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 13, 2022 at 7:47AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:47AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:47AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:47AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022

πŸ¦‹ Changeset detected

Latest commit: e76cc01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 43.01% // Head: 47.08% // Increases project coverage by +4.06% πŸŽ‰

Coverage data is based on head (e76cc01) compared to base (eee8334).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1359      +/-   ##
===========================================
+ Coverage    43.01%   47.08%   +4.06%     
===========================================
  Files          609      667      +58     
  Lines        25472    29577    +4105     
  Branches      6978     7808     +830     
===========================================
+ Hits         10957    13925    +2968     
- Misses       13382    15596    +2214     
+ Partials      1133       56    -1077     
Flag Coverage Ξ”
test 47.08% <ΓΈ> (+4.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ΓΈ)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ΓΈ)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ΓΈ)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ΓΈ)
libs/ledger-live-common/src/apps/logic.ts 89.71% <0.00%> (ΓΈ)
... and 295 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

@mcayuelas-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
discover-actual discover-diff discover-expected
discover-actual discover-diff discover-expected

@@ -1481,7 +1481,7 @@
"cta": "I’m ready to scan",
"bullets": {
"0": {
"label": "On the Desktop app, select <1>Settings > Accounts > Account export</1>."
"label": "On the Desktop app, select\n<1>Settings > Accounts > Account export</1>."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that legit and understood by React Native as new line? TiL

@github-actions
Copy link

@mcayuelas-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@mcayuelas-ledger mcayuelas-ledger merged commit 32daa00 into develop Oct 13, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the support/llm-sync-from-desktop branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants