Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(URLs): LLM - Terms and Privacy Policy urls to update #1365

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 26, 2022

πŸ“ Description

Terms and Privacy Policy urls to update on LLM

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3794

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen_Recording_20220926-113019_Samsung.Internet.mp4

Fix for PT and RU in Prod

Screen_Recording_20220926-160113_LL.DEV.mp4

πŸš€ Expectations to reach

First screen Onboarding > change language > Test links
Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 26, 2022 at 2:12PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 26, 2022 at 2:12PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 26, 2022 at 2:12PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 26, 2022 at 2:12PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

πŸ¦‹ Changeset detected

Latest commit: ee95ada

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 48.12% // Head: 43.64% // Decreases project coverage by -4.47% ⚠️

Coverage data is based on head (6af4a22) compared to base (521582f).
Patch has no changes to coverable lines.

❗ Current head 6af4a22 differs from pull request most recent head ee95ada. Consider uploading reports for the commit ee95ada to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1365      +/-   ##
===========================================
- Coverage    48.12%   43.64%   -4.48%     
===========================================
  Files          688      610      -78     
  Lines        30322    25543    -4779     
  Branches      7905     6971     -934     
===========================================
- Hits         14591    11148    -3443     
+ Misses       15668    14346    -1322     
+ Partials        63       49      -14     
Flag Coverage Ξ”
test 43.64% <ΓΈ> (-4.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ΓΈ)
...edgerjs/packages/hw-app-btc/src/signTransaction.ts
libs/ledgerjs/packages/cryptoassets/data/trc10.js
libs/ledgerjs/packages/devices/src/index.ts
.../ledgerjs/packages/hw-app-btc/src/newops/psbtv2.ts
...s/hw-app-btc/src/shouldUseTrustedInputForSegwit.ts
libs/ledgerjs/packages/hw-app-xrp/src/Xrp.ts
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts
...dgerjs/packages/hw-app-helium/src/serialization.ts
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 26, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit 2d618e1 into develop Sep 26, 2022
@LFBarreto LFBarreto deleted the support/llm-terms-and-privacy-policy branch September 26, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants