Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/live 2987/rtl arabic support #1369

Merged
merged 39 commits into from
Oct 18, 2022
Merged

Conversation

mle-gall
Copy link
Contributor

@mle-gall mle-gall commented Sep 26, 2022

πŸ“ Description

Implementing Right to Left support and Arabic Language support

❓ Context

  • Impacted projects: LLM, LibUI
  • Linked resource(s): LIVE-2987

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen_Recording_20220923-124816_LL.STAGING.mp4

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@mle-gall mle-gall requested a review from a team September 26, 2022 11:58
@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 17, 2022 at 4:05PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 17, 2022 at 4:05PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 17, 2022 at 4:05PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 17, 2022 at 4:05PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

πŸ¦‹ Changeset detected

Latest commit: 5d31626

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library labels Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 0.00% // Head: 44.95% // Increases project coverage by +44.95% πŸŽ‰

Coverage data is based on head (2070034) compared to base (c88f557).
Patch has no changes to coverable lines.

❗ Current head 2070034 differs from pull request most recent head 5d31626. Consider uploading reports for the commit 5d31626 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1369       +/-   ##
============================================
+ Coverage         0   44.95%   +44.95%     
============================================
  Files            0      633      +633     
  Lines            0    26696    +26696     
  Branches         0     7229     +7229     
============================================
+ Hits             0    12000    +12000     
- Misses           0    14645    +14645     
- Partials         0       51       +51     
Flag Coverage Ξ”
test 44.95% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/apps/support.ts 54.54% <0.00%> (ΓΈ)
...edger-live-common/src/families/cosmos/bridge/js.ts 53.33% <0.00%> (ΓΈ)
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (ΓΈ)
...e-common/src/families/hedera/js-synchronisation.ts 34.37% <0.00%> (ΓΈ)
...r-live-common/src/currencies/formatCurrencyUnit.ts 89.47% <0.00%> (ΓΈ)
...ger-live-common/src/families/algorand/api/index.ts 100.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/pagination.ts 7.14% <0.00%> (ΓΈ)
...live-common/src/families/filecoin/hw-getAddress.ts 41.66% <0.00%> (ΓΈ)
...ledger-live-common/src/families/algorand/tokens.ts 66.66% <0.00%> (ΓΈ)
...r-live-common/src/families/crypto_org/bridge/js.ts 84.61% <0.00%> (ΓΈ)
... and 623 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 26, 2022

@mlegall-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general comment: the usage of .svg in our app has grown and it could cause performance problem. it's generally recommended to use images (x1, x2, x3) on mobile for performance.

i let other devs review this PR πŸ™

…IVE-2987/RTL-arabic-support # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…nt issues in RTL mode. Modified arabic language name
@gre
Copy link
Contributor

gre commented Oct 17, 2022

FYI this PR have conflicts @mlegall-ledger

@mle-gall
Copy link
Contributor Author

FYI this PR have conflicts @mlegall-ledger

Fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM screenshots Screenshots have been updated translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants