Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(CroppedText): LLM - Onboarding - Terms and Privacy urls should not overflow screen in the small screen #1380

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 27, 2022

πŸ“ Description

LLM - Onboarding - Terms and Privacy urls should not overflow screen in the small screen

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3897

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen_Recording_20220927-104004_LL.DEV.mp4

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 13, 2022 at 7:40AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:40AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:40AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:40AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

πŸ¦‹ Changeset detected

Latest commit: d4a89f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Oct 13, 2022
@github-actions
Copy link

@mcayuelas-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
discover-actual discover-diff discover-expected
discover-actual discover-diff discover-expected

@mcayuelas-ledger mcayuelas-ledger merged commit c88f557 into develop Oct 17, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the support/llm-onboarding-cropped branch October 17, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants