Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3905 - LLD - fix toast issue when no click callback given #1381

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Sep 27, 2022

📝 Description

Failsafes an issue reported by sentry related to undefined toast callback causing crashes

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): LIVE-3905

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 9:28AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 27, 2022 at 9:28AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2022 at 9:28AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2022 at 9:28AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: d95783a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LFBarreto LFBarreto marked this pull request as ready for review September 27, 2022 09:17
@github-actions github-actions bot added the desktop Has changes in LLD label Sep 27, 2022
@LFBarreto LFBarreto force-pushed the bugfix/LIVE-3905-toast-without-callback-issue branch from 3b6f199 to d95783a Compare September 27, 2022 09:27
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 0.00% // Head: 48.11% // Increases project coverage by +48.11% 🎉

Coverage data is based on head (d95783a) compared to base (abd8410).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           release    #1381       +/-   ##
============================================
+ Coverage         0   48.11%   +48.11%     
============================================
  Files            0      688      +688     
  Lines            0    30302    +30302     
  Branches         0     7894     +7894     
============================================
+ Hits             0    14580    +14580     
- Misses           0    14521    +14521     
- Partials         0     1201     +1201     
Flag Coverage Δ
test 48.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ledger-live-common/src/exchange/swap/submitKYC.ts 50.00% <0.00%> (ø)
...n/src/families/bitcoin/wallet-btc/crypto/decred.ts 51.78% <0.00%> (ø)
...bs/ledger-live-common/src/generated/bridge/mock.ts 100.00% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-eth/src/errors.ts 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/trc10.js 100.00% <0.00%> (ø)
...r-live-common/src/families/solana/serialization.ts 33.33% <0.00%> (ø)
.../families/bitcoin/wallet-btc/crypto/bitcoincash.ts 75.00% <0.00%> (ø)
...live-common/src/families/ethereum/signOperation.ts 23.17% <0.00%> (ø)
...lies/bitcoin/wallet-btc/pickingstrategies/Merge.ts 89.74% <0.00%> (ø)
...on/src/families/elrond/js-getFeesForTransaction.ts 57.14% <0.00%> (ø)
... and 678 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

@LFBarreto

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

windows

Actual Diff Expected
discover-actual discover-diff discover-expected
discover-actual discover-diff discover-expected

@LFBarreto LFBarreto merged commit acb89e2 into release Sep 27, 2022
@LFBarreto LFBarreto deleted the bugfix/LIVE-3905-toast-without-callback-issue branch September 27, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants