Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(i18n): The text Fingerprint should be translated #1384

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 27, 2022

📝 Description

The text Fingerprint should be translated

FaceID / TouchID/ Fringerprint are handled. If new ones come, there is a Fallback (it will be written in English) but no translation will be provided without updating translation file.

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3869

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Go General > Settings (have Fringerprint or FaceID activated on your device)
Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 0:43AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 4, 2022 at 0:43AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 0:43AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 0:43AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: 802e40d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 27, 2022
@github-actions
Copy link

@mcayuelas-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@LFBarreto LFBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 51.77% // Head: 43.58% // Decreases project coverage by -8.19% ⚠️

Coverage data is based on head (802e40d) compared to base (7921eec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1384      +/-   ##
===========================================
- Coverage    51.77%   43.58%   -8.20%     
===========================================
  Files            6      610     +604     
  Lines          253    25471   +25218     
  Branches        26     6974    +6948     
===========================================
+ Hits           131    11102   +10971     
- Misses         122    13242   +13120     
- Partials         0     1127    +1127     
Flag Coverage Δ
test 43.58% <ø> (-8.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/hw-transport-mocker/src/openTransportReplayer.ts
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts
...hw-transport-mocker/src/createTransportRecorder.ts
...hw-transport-mocker/src/createTransportReplayer.ts
...ledgerjs/packages/hw-transport-mocker/src/index.ts
...js/packages/hw-transport-mocker/src/RecordStore.ts
...s/ledger-live-common/src/families/cosmos/banner.ts 97.56% <0.00%> (ø)
libs/ledger-live-common/src/bridge/index.ts 37.50% <0.00%> (ø)
...mon/src/families/hedera/deviceTransactionConfig.ts 7.69% <0.00%> (ø)
libs/ledger-live-common/src/bridge/impl.ts 71.42% <0.00%> (ø)
... and 606 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcayuelas-ledger mcayuelas-ledger merged commit b3a787f into develop Oct 4, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the support/llm-i18n-biometrics branch October 4, 2022 13:59
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

@mcayuelas-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

adrienlacombe pushed a commit that referenced this pull request Oct 5, 2022
* bugfix(i18n): The text Fingerprint should be translated

* 📝 Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants