Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LIVE-3913 Updated share library (fixes export logs and ops) #1397

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

During testing of another feature we found out that saving logs was no longer working on Android > 12. Since this library is used to also export operations it's likely it's impacting that feature too. That issue was addressed by the developers of the library some versions ago and simply bumping it solves it.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-3913

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 0:01AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 5, 2022 at 0:01AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 5, 2022 at 0:01AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 5, 2022 at 0:01AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: da519b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 45.26% // Head: 45.26% // No change to project coverage 👍

Coverage data is based on head (087f650) compared to base (087f650).
Patch has no changes to coverable lines.

❗ Current head 087f650 differs from pull request most recent head da519b9. Consider uploading reports for the commit da519b9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1397   +/-   ##
========================================
  Coverage    45.26%   45.26%           
========================================
  Files          632      632           
  Lines        26585    26585           
  Branches      7207     7207           
========================================
  Hits         12035    12035           
  Misses       13413    13413           
  Partials      1137     1137           
Flag Coverage Δ
test 45.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juan-cortes
Copy link
Contributor Author

QA ok by @alalmi-ledger merging

@juan-cortes
Copy link
Contributor Author

Well, after CI tells me I can

@github-actions
Copy link

github-actions bot commented Sep 27, 2022

@juan-cortes

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

@juan-cortes

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants