-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/LIVE-3913 Updated share library (fixes export logs and ops) #1397
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: da519b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 45.26% // Head: 45.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1397 +/- ##
========================================
Coverage 45.26% 45.26%
========================================
Files 632 632
Lines 26585 26585
Branches 7207 7207
========================================
Hits 12035 12035
Misses 13413 13413
Partials 1137 1137
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
QA ok by @alalmi-ledger merging |
Well, after CI tells me I can |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
4144dc9
to
4b0d49c
Compare
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
4b0d49c
to
da519b9
Compare
📝 Description
During testing of another feature we found out that saving logs was no longer working on Android > 12. Since this library is used to also export operations it's likely it's impacting that feature too. That issue was addressed by the developers of the library some versions ago and simply bumping it solves it.
❓ Context
ledger-live-mobile
https://ledgerhq.atlassian.net/browse/LIVE-3913
✅ Checklist