💄 support(UI): Onboarding quizz pixel polish LLM #1402

mcayuelas-ledger · 2022-09-28T09:09:23Z

📝 Description

Onboarding quizz pixel polish LLM

❓ Context

Impacted projects: live-mobile
Linked resource(s): LIVE-2091

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

Screen_Recording_20220928-105705_LL.DEV.mp4

🚀 Expectations to reach

OnBoarding > Configure Nano

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

vercel · 2022-09-28T09:09:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Oct 6, 2022 at 0:30AM (UTC)

3 Ignored Deployments

Name	Status	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)	Oct 6, 2022 at 0:30AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)	Oct 6, 2022 at 0:30AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)	Oct 6, 2022 at 0:30AM (UTC)

changeset-bot · 2022-09-28T09:09:26Z

🦋 Changeset detected

Latest commit: 3e9ec68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
live-mobile	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2022-09-28T09:38:39Z

Codecov Report

Base: 0.00% // Head: 43.59% // Increases project coverage by +43.59% 🎉

Coverage data is based on head (37ac299) compared to base (ecb00cf).
Patch has no changes to coverable lines.

❗ Current head 37ac299 differs from pull request most recent head 3e9ec68. Consider uploading reports for the commit 3e9ec68 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #1402       +/-   ##
============================================
+ Coverage         0   43.59%   +43.59%     
============================================
  Files            0      610      +610     
  Lines            0    25476    +25476     
  Branches         0     6974     +6974     
============================================
+ Hits             0    11105    +11105     
- Misses           0    14321    +14321     
- Partials         0       50       +50

Flag	Coverage Δ
test	`43.59% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libs/ledger-live-common/src/exchange/index.ts	`37.03% <0.00%> (ø)`
...er-live-common/src/families/tezos/hw-getAddress.ts	`50.00% <0.00%> (ø)`
...mmon/src/families/solana/api/chain/account/vote.ts	`100.00% <0.00%> (ø)`
...ger-live-common/src/families/elrond/transaction.ts	`38.09% <0.00%> (ø)`
...ve-common/src/families/crypto_org/serialization.ts	`33.33% <0.00%> (ø)`
...s/ledger-live-common/src/families/cardano/types.ts	`100.00% <0.00%> (ø)`
...dger-live-common/src/families/hedera/js-receive.ts	`41.17% <0.00%> (ø)`
...ive-common/src/families/filecoin/hw-signMessage.ts	`41.66% <0.00%> (ø)`
...s/ledger-live-common/src/families/bitcoin/cache.ts	`33.33% <0.00%> (ø)`
...ive-common/src/families/ethereum/hw-signMessage.ts	`100.00% <0.00%> (ø)`
... and 600 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2022-09-28T10:27:57Z

@mcayuelas-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

nparigi-ledger · 2022-10-06T09:49:36Z

apps/ledger-live-mobile/src/screens/Onboarding/steps/newDeviceInfo.tsx

@@ -33,7 +36,7 @@ const Card = ({ index /* , deviceModelId */ }: CardType) => {
  const { t } = useTranslation();
  return (
    <Flex flex={1} justifyContent="center" alignItems="center" px={20}>
-      <Flex>
+      <Flex mb={`${space[8]}px`}>


You just need to do Flex mb=8, it should not be imported like this

nparigi-ledger · 2022-10-06T09:55:37Z

apps/ledger-live-mobile/src/screens/Onboarding/steps/newDeviceInfo.tsx

+    width: "100%",
+  },
+  backArrow: {
+    position: "absolute",


<Button> component should already accept these position props

nparigi-ledger · 2022-10-06T09:57:59Z

apps/ledger-live-mobile/src/screens/Onboarding/steps/newDeviceInfo.tsx

      </Flex>
+      <InvertTheme>


I'm not sure what the expected behavior of this, but i think you wanted to use something like this :
<ForceTheme selectedPalette={"dark"}>

github-actions · 2022-10-06T13:14:06Z

@mcayuelas-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual	Diff	Expected
v3-onboarding-complete-actual	v3-onboarding-complete-diff	v3-onboarding-complete-expected

windows

Actual	Diff	Expected
discover-actual	discover-diff	discover-expected

github-actions bot assigned mcayuelas-ledger Sep 28, 2022

github-actions bot added the mobile Has changes in LLM label Sep 28, 2022

vercel bot deployed to Preview – live-common-tools September 28, 2022 09:09 View deployment

vercel bot deployed to Preview – live-common-tools September 28, 2022 09:33 View deployment

mcayuelas-ledger added 2 commits September 29, 2022 09:51

💄 support(UI): Onboarding quizz pixel polish LLM

f610f5c

📝 Changelog

fdc072d

mcayuelas-ledger force-pushed the support/llm-onboarding-pixel-polishing branch from 08e11d9 to fdc072d Compare September 29, 2022 07:51

vercel bot deployed to Preview – live-common-tools September 29, 2022 07:53 View deployment

nparigi-ledger reviewed Oct 6, 2022

View reviewed changes

📝 Review

37ac299

vercel bot deployed to Preview – live-common-tools October 6, 2022 10:02 View deployment

📝 Review

3e9ec68

mcayuelas-ledger requested a review from nparigi-ledger October 6, 2022 12:27

vercel bot deployed to Preview – live-common-tools October 6, 2022 12:30 View deployment

LFBarreto approved these changes Oct 11, 2022

View reviewed changes

LFBarreto merged commit 1cc596a into develop Oct 11, 2022

LFBarreto deleted the support/llm-onboarding-pixel-polishing branch October 11, 2022 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

💄 support(UI): Onboarding quizz pixel polish LLM #1402

💄 support(UI): Onboarding quizz pixel polish LLM #1402

mcayuelas-ledger commented Sep 28, 2022 •

edited by jira bot

Loading

vercel bot commented Sep 28, 2022 •

edited

Loading

changeset-bot bot commented Sep 28, 2022 •

edited

Loading

codecov bot commented Sep 28, 2022 •

edited

Loading

github-actions bot commented Sep 28, 2022 •

edited

Loading

nparigi-ledger Oct 6, 2022

nparigi-ledger Oct 6, 2022 •

edited

Loading

nparigi-ledger Oct 6, 2022

github-actions bot commented Oct 6, 2022

💄 support(UI): Onboarding quizz pixel polish LLM #1402

💄 support(UI): Onboarding quizz pixel polish LLM #1402

Conversation

mcayuelas-ledger commented Sep 28, 2022 • edited by jira bot Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

vercel bot commented Sep 28, 2022 • edited Loading

changeset-bot bot commented Sep 28, 2022 • edited Loading

🦋 Changeset detected

codecov bot commented Sep 28, 2022 • edited Loading

Codecov Report

github-actions bot commented Sep 28, 2022 • edited Loading

nparigi-ledger Oct 6, 2022

Choose a reason for hiding this comment

nparigi-ledger Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

nparigi-ledger Oct 6, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 6, 2022

mcayuelas-ledger commented Sep 28, 2022 •

edited by jira bot

Loading

vercel bot commented Sep 28, 2022 •

edited

Loading

changeset-bot bot commented Sep 28, 2022 •

edited

Loading

codecov bot commented Sep 28, 2022 •

edited

Loading

github-actions bot commented Sep 28, 2022 •

edited

Loading

nparigi-ledger Oct 6, 2022 •

edited

Loading