Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support(QuickActions): Asset Receive Quick action Improvement #1406

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 28, 2022

πŸ“ Description

Asset Receive Quick action Improvement

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-3715

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen_Recording_20220928-151915_LL.DEV.mp4

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 28, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 13, 2022 at 7:42AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:42AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:42AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:42AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

πŸ¦‹ Changeset detected

Latest commit: 8985afa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 43.01% // Head: 72.15% // Increases project coverage by +29.14% πŸŽ‰

Coverage data is based on head (8985afa) compared to base (eee8334).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1406       +/-   ##
============================================
+ Coverage    43.01%   72.15%   +29.14%     
============================================
  Files          609       15      -594     
  Lines        25472      510    -24962     
  Branches      6978       88     -6890     
============================================
- Hits         10957      368    -10589     
+ Misses       13382      134    -13248     
+ Partials      1133        8     -1125     
Flag Coverage Ξ”
test 72.15% <ΓΈ> (+29.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...ger-live-common/src/migrations/accounts-dataset.ts
...er-live-common/src/families/evm/synchronization.ts
...-common/src/families/celo/js-prepareTransaction.ts
...common/src/families/osmosis/js-buildTransaction.ts
libs/ledger-live-common/src/families/evm/logic.ts
.../ledger-live-common/src/account/groupOperations.ts
...ilies/solana/api/chain/instruction/system/index.ts
...er-live-common/src/countervalues/modules/ethbtc.ts
...s/ledger-live-common/src/currencies/formatShort.ts
...mmon/src/families/stellar/js-prepareTransaction.ts
... and 614 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 28, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions
Copy link

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@mcayuelas-ledger mcayuelas-ledger merged commit 10a662a into develop Oct 17, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the support/llm-quick-actions-improvment branch October 17, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants