Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/live 2551 device model info apps undefined value fixed #1414

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Sep 29, 2022

📝 Description

Fixed the lastSeenDevice apps property that wasn't set properly in some cases

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-2551

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 1:11PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 4, 2022 at 1:11PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 1:11PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 1:11PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: d843b44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 45.95% // Head: 45.95% // No change to project coverage 👍

Coverage data is based on head (1592d5e) compared to base (1592d5e).
Patch has no changes to coverable lines.

❗ Current head 1592d5e differs from pull request most recent head d843b44. Consider uploading reports for the commit d843b44 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1414   +/-   ##
========================================
  Coverage    45.95%   45.95%           
========================================
  Files          644      644           
  Lines        27529    27529           
  Branches      7371     7371           
========================================
  Hits         12652    12652           
  Misses       14814    14814           
  Partials        63       63           
Flag Coverage Δ
test 45.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

@cgrellard-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@LFBarreto LFBarreto force-pushed the bugfix/LIVE-2551-device-model-info-apps-undefined-value-fixed branch from 9f77999 to d843b44 Compare October 4, 2022 13:05
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

@LFBarreto

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
discover-actual discover-diff discover-expected
discover-actual discover-diff discover-expected

@LFBarreto LFBarreto merged commit 48bc769 into develop Oct 10, 2022
@LFBarreto LFBarreto deleted the bugfix/LIVE-2551-device-model-info-apps-undefined-value-fixed branch October 10, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants