Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3253 - LLM - add referral program discover card #1439

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

LFBarreto
Copy link
Contributor

📝 Description

Adds a feature flagged referral program entry point to discover section

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3253

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

screenshot

Screenshot_2022-10-03-11-06-25-583_com ledger live debug

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

🦋 Changeset detected

Latest commit: c33c82c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
live-mobile Patch
@ledgerhq/types-live Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 9:28AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 3, 2022 at 9:28AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 3, 2022 at 9:28AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 3, 2022 at 9:28AM (UTC)

@github-actions github-actions bot added ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched labels Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 47.70% // Head: 48.11% // Increases project coverage by +0.41% 🎉

Coverage data is based on head (c33c82c) compared to base (e9b7743).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1439      +/-   ##
===========================================
+ Coverage    47.70%   48.11%   +0.41%     
===========================================
  Files          674      689      +15     
  Lines        29821    30331     +510     
  Branches      7823     7911      +88     
===========================================
+ Hits         14227    14595     +368     
- Misses       14398    14589     +191     
+ Partials      1196     1147      -49     
Flag Coverage Δ
test 48.11% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-btc/src/BtcNew.ts 92.25% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-btc/src/varint.ts 30.76% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-tezos/src/Tezos.ts 11.34% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts 20.73% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts 89.28% <0.00%> (ø)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ø)
.../ledgerjs/packages/hw-app-btc/src/newops/psbtv2.ts 67.51% <0.00%> (ø)
.../ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts 20.77% <0.00%> (ø)
...dgerjs/packages/hw-app-btc/src/newops/appClient.ts 23.07% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@LFBarreto

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@LFBarreto LFBarreto merged commit eb47f9e into develop Oct 3, 2022
@LFBarreto LFBarreto deleted the feat/LIVE-3253-referral-program-discover-card branch October 3, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants