Add deeplink for synchronous onboarding #1455

thomasrogerlux · 2022-10-04T08:31:30Z

📝 Description

Add a deeplink redirecting to the new sync onboarding if terms were accepted, or just redirecting to the start screen if they were not. More infos in proper Slack channels.

❓ Context

Impacted projects: ledger-live-mobile
Linked resource(s): FAT-456

✅ Checklist

~~Test coverage~~ no tests on mobile yet
Atomic delivery
No breaking changes

📸 Demo

See proper slack channels for demo.

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

vercel · 2022-10-04T08:31:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Oct 25, 2022 at 9:42AM (UTC)

3 Ignored Deployments

Name	Status	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)	Oct 25, 2022 at 9:42AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)	Oct 25, 2022 at 9:42AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)	Oct 25, 2022 at 9:42AM (UTC)

changeset-bot · 2022-10-04T08:31:34Z

🦋 Changeset detected

Latest commit: 9eef4ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
live-mobile	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2022-10-04T08:56:59Z

Codecov Report

Base: 47.57% // Head: 0.00% // Decreases project coverage by -47.57% ⚠️

Coverage data is based on head (c9b328f) compared to base (df8cbb8).
Patch has no changes to coverable lines.

❗ Current head c9b328f differs from pull request most recent head 9eef4ef. Consider uploading reports for the commit 9eef4ef to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #1455       +/-   ##
===========================================
- Coverage    47.57%       0   -47.58%     
===========================================
  Files          679       0      -679     
  Lines        30143       0    -30143     
  Branches      7900       0     -7900     
===========================================
- Hits         14340       0    -14340     
+ Misses       15738       0    -15738     
+ Partials        65       0       -65

Flag	Coverage Δ
test	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ger-live-common/src/families/celo/hw-getAddress.ts
...mon/src/families/solana/api/chain/program/index.ts
libs/ledger-live-common/src/currencies/color.ts
...ive-common/src/families/filecoin/hw-signMessage.ts
...mon/src/families/bitcoin/wallet-btc/crypto/pivx.ts
libs/ledgerjs/packages/hw-app-btc/src/BtcNew.ts
libs/ledger-live-common/src/platform/version.ts
...ledger-live-common/src/api/explorerConfig/index.ts
...s/ledger-live-common/src/exchange/swap/initSwap.ts
.../ledger-live-common/src/families/stellar/errors.ts
... and 669 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2022-10-04T09:09:17Z

@thomasrogerlux

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual	Diff	Expected
v3-onboarding-complete-actual	v3-onboarding-complete-diff	v3-onboarding-complete-expected

apps/ledger-live-mobile/src/components/RootNavigator/BaseNavigator.tsx

apps/ledger-live-mobile/src/screens/BleDevicePairingFlow/index.tsx

apps/ledger-live-mobile/src/components/RootNavigator/BaseNavigator.tsx

apps/ledger-live-mobile/src/index.tsx

apps/ledger-live-mobile/src/screens/BleDevicePairingFlow/index.tsx

* feat(mobile): add a deeplink redirection to sync onboarding * chore: generate changeset * refactor(mobile): redo the deeplink redirection cleanly * fix(mobile): update how terms are checked * chore(mobile): update code doc for pairing flow navigation * fix(mobile): revert default navigation to previous state in pairing flow * fix(mobile): add some comments * fix(mobile): rechange navigation type stuff * fix(mobile): redirect properly to welcome screen when hitting back

thomasrogerlux requested a review from a team as a code owner October 4, 2022 08:31

github-actions bot added cli common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library labels Oct 4, 2022

github-actions bot assigned thomasrogerlux Oct 4, 2022

thomasrogerlux force-pushed the feat/FAT-456-sync-onboarding-deeplink branch from 6e55688 to 02bb5b9 Compare October 4, 2022 08:34

github-actions bot removed ledgerjs Has changes in the ledgerjs open source libs cli ui Has changes in the design system library common Has changes in live-common translations Translation files have been touched labels Oct 4, 2022

vercel bot deployed to Preview – live-common-tools October 4, 2022 08:35 View deployment

vercel bot deployed to Preview – live-common-tools October 4, 2022 08:38 View deployment

thomasrogerlux marked this pull request as draft October 4, 2022 13:11

alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from b418304 to 52a8bf8 Compare October 5, 2022 07:01

thomasrogerlux force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from 70cb9d1 to 76d07e1 Compare October 6, 2022 14:35

alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch 2 times, most recently from 6277f05 to f9426bd Compare October 10, 2022 13:29

thomasrogerlux force-pushed the feat/FAT-456-sync-onboarding-deeplink branch from 03bda8f to 16200f4 Compare October 11, 2022 11:42

vercel bot deployed to Preview – live-common-tools October 11, 2022 11:43 View deployment

alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch 3 times, most recently from cc643b3 to 82b71c8 Compare October 12, 2022 10:55

alexandremgo reviewed Oct 14, 2022

View reviewed changes

apps/ledger-live-mobile/src/components/RootNavigator/BaseNavigator.tsx Show resolved Hide resolved

alexandremgo reviewed Oct 14, 2022

View reviewed changes

apps/ledger-live-mobile/src/screens/BleDevicePairingFlow/index.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – live-common-tools October 14, 2022 12:38 View deployment

alexandremgo reviewed Oct 14, 2022

View reviewed changes

thomasrogerlux force-pushed the feat/FAT-456-sync-onboarding-deeplink branch from 7455661 to ac64c63 Compare October 17, 2022 08:13

vercel bot deployed to Preview – live-common-tools October 17, 2022 08:14 View deployment

vercel bot deployed to Preview – live-common-tools October 17, 2022 08:18 View deployment

alexandremgo reviewed Oct 17, 2022

View reviewed changes

apps/ledger-live-mobile/src/screens/BleDevicePairingFlow/index.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – live-common-tools October 17, 2022 08:40 View deployment

alexandremgo approved these changes Oct 17, 2022

View reviewed changes

thomasrogerlux force-pushed the feat/FAT-456-sync-onboarding-deeplink branch from 9a58a76 to 0847b0b Compare October 21, 2022 08:30

vercel bot deployed to Preview – live-common-tools October 21, 2022 08:31 View deployment

vercel bot deployed to Preview – live-common-tools October 21, 2022 15:08 View deployment

thomasrogerlux added 9 commits October 25, 2022 11:37

feat(mobile): add a deeplink redirection to sync onboarding

2a2a9fb

chore: generate changeset

dbb89b0

refactor(mobile): redo the deeplink redirection cleanly

fb2f510

fix(mobile): update how terms are checked

35020dc

chore(mobile): update code doc for pairing flow navigation

5b0992d

fix(mobile): revert default navigation to previous state in pairing flow

61e6ad2

fix(mobile): add some comments

01a40c0

fix(mobile): rechange navigation type stuff

aa226fb

fix(mobile): redirect properly to welcome screen when hitting back

9eef4ef

thomasrogerlux force-pushed the feat/FAT-456-sync-onboarding-deeplink branch from c9b328f to 9eef4ef Compare October 25, 2022 09:38

vercel bot deployed to Preview – live-common-tools October 25, 2022 09:39 View deployment

thomasrogerlux merged commit 61240d2 into develop Oct 25, 2022

thomasrogerlux deleted the feat/FAT-456-sync-onboarding-deeplink branch October 25, 2022 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deeplink for synchronous onboarding #1455

Add deeplink for synchronous onboarding #1455

thomasrogerlux commented Oct 4, 2022 •

edited by jira bot

Loading

vercel bot commented Oct 4, 2022 •

edited

Loading

changeset-bot bot commented Oct 4, 2022 •

edited

Loading

codecov bot commented Oct 4, 2022 •

edited

Loading

github-actions bot commented Oct 4, 2022 •

edited

Loading

Add deeplink for synchronous onboarding #1455

Add deeplink for synchronous onboarding #1455

Conversation

thomasrogerlux commented Oct 4, 2022 • edited by jira bot Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

vercel bot commented Oct 4, 2022 • edited Loading

changeset-bot bot commented Oct 4, 2022 • edited Loading

🦋 Changeset detected

codecov bot commented Oct 4, 2022 • edited Loading

Codecov Report

github-actions bot commented Oct 4, 2022 • edited Loading

thomasrogerlux commented Oct 4, 2022 •

edited by jira bot

Loading

vercel bot commented Oct 4, 2022 •

edited

Loading

changeset-bot bot commented Oct 4, 2022 •

edited

Loading

codecov bot commented Oct 4, 2022 •

edited

Loading

github-actions bot commented Oct 4, 2022 •

edited

Loading