Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM - Braze SDK Integration #1467

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Oct 5, 2022

πŸ“ Description

Integrated Braze's SDK to LLM

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3678

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 31, 2022 at 11:27AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 31, 2022 at 11:27AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 31, 2022 at 11:27AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 31, 2022 at 11:27AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2022

πŸ¦‹ Changeset detected

Latest commit: edc5cc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 47.60% // Head: 47.94% // Increases project coverage by +0.34% πŸŽ‰

Coverage data is based on head (8a322e4) compared to base (1bf042c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/LIVE-3675-braze-integration    #1467      +/-   ##
====================================================================
+ Coverage                             47.60%   47.94%   +0.34%     
====================================================================
  Files                                   687      691       +4     
  Lines                                 30260    30445     +185     
  Branches                               7913     7977      +64     
====================================================================
+ Hits                                  14406    14598     +192     
  Misses                                14635    14635              
+ Partials                               1219     1212       -7     
Flag Coverage Ξ”
test 47.94% <ΓΈ> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...ger-live-common/src/families/evm/api/rpc.common.ts 36.36% <0.00%> (-7.28%) ⬇️
libs/ledger-live-common/src/env.ts 74.50% <0.00%> (-5.93%) ⬇️
...s/packages/hw-app-eth/src/services/ledger/erc20.ts 93.44% <0.00%> (-4.00%) ⬇️
...mon/src/families/elrond/js-getTransactionStatus.ts 15.15% <0.00%> (-0.98%) ⬇️
libs/ledgerjs/packages/errors/src/index.ts 76.02% <0.00%> (-0.90%) ⬇️
...ger-live-common/src/families/ripple/bridge/mock.ts 70.31% <0.00%> (-0.66%) ⬇️
libs/ledger-live-common/src/hw/actions/app.ts 10.39% <0.00%> (-0.16%) ⬇️
libs/ledger-live-common/src/errors.ts 100.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/apps/polyfill.ts 89.47% <0.00%> (ΓΈ)
...ibs/ledger-live-common/src/manager/localization.ts 100.00% <0.00%> (ΓΈ)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

@cgrellard-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Oct 22, 2022
@cgrellard-ledger cgrellard-ledger force-pushed the feat/LIVE-3678-braze-sdk-setup-on-llm branch from 31d2b88 to f3c4e3c Compare October 25, 2022 13:00
@github-actions github-actions bot added automation CI/CD stuff cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs screenshots Screenshots have been updated tools Has changes in tools translations Translation files have been touched ui Has changes in the design system library labels Oct 25, 2022
@cgrellard-ledger cgrellard-ledger force-pushed the feat/LIVE-3678-braze-sdk-setup-on-llm branch from f3c4e3c to c1a0be2 Compare October 25, 2022 13:49
@github-actions github-actions bot removed automation CI/CD stuff ui Has changes in the design system library desktop Has changes in LLD cli screenshots Screenshots have been updated common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Oct 25, 2022
@github-actions github-actions bot added the translations Translation files have been touched label Oct 31, 2022
…Q/ledger-live into feat/LIVE-3678-braze-sdk-setup-on-llm
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review October 31, 2022 11:23
@cgrellard-ledger cgrellard-ledger requested a review from a team October 31, 2022 11:23
@github-actions github-actions bot removed common Has changes in live-common screenshots Screenshots have been updated ledgerjs Has changes in the ledgerjs open source libs desktop Has changes in LLD automation CI/CD stuff ui Has changes in the design system library cli tools Has changes in tools labels Oct 31, 2022
@cgrellard-ledger cgrellard-ledger merged commit 59f50d5 into feat/LIVE-3675-braze-integration Oct 31, 2022
@cgrellard-ledger cgrellard-ledger deleted the feat/LIVE-3678-braze-sdk-setup-on-llm branch October 31, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM Stale translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet