Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/FAT-133 Install set of apps from device actions + tool #1474

Merged
merged 8 commits into from
Oct 10, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

A step of the sync onboarding so this can only be tested through the Debug menu. This PR introduces the possibility of installing a set of apps from a remote firebase config to be used as part of a device setup flow. Only available on provider 12. Final wording and UI polishes to be done as part of FAT-82.

❓ Context

  • Impacted projects: ledger-live-common, ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/FAT-133

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

image

🚀 Expectations to reach

It's very important ⚠️ for QA to focus on non regression for other flows that rely on device actions due to the changes introduced in this component. Those changes allow for a user of a device action to implement its own UI overriding the default one from DeviceAction but I might have broken something in the process.

I would say cover send/receive/add accounts with error cases (unplug device, disconnect, reject).
Apart from the actual flow for the epic.

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@juan-cortes juan-cortes requested a review from a team as a code owner October 5, 2022 14:11
@github-actions github-actions bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched labels Oct 5, 2022
@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 0:48AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 10, 2022 at 0:48AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 10, 2022 at 0:48AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 10, 2022 at 0:48AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2022

🦋 Changeset detected

Latest commit: 558c96d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@ledgerhq/live-common Minor
@ledgerhq/types-live Patch
live-mobile Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juan-cortes juan-cortes changed the title feat/FAT-133 feat/FAT-133 Install set of apps from device actions + tool Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

@alexandremgo

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 44.86% // Head: 46.46% // Increases project coverage by +1.59% 🎉

Coverage data is based on head (1d38af7) compared to base (38012bc).
Patch coverage: 8.33% of modified lines in pull request are covered.

❗ Current head 1d38af7 differs from pull request most recent head 558c96d. Consider uploading reports for the commit 558c96d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1474      +/-   ##
===========================================
+ Coverage    44.86%   46.46%   +1.59%     
===========================================
  Files          627      659      +32     
  Lines        26903    28075    +1172     
  Branches      7259     7527     +268     
===========================================
+ Hits         12071    13046     +975     
- Misses       13687    13897     +210     
+ Partials      1145     1132      -13     
Flag Coverage Δ
test 46.46% <8.33%> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/apps/runner.ts 52.83% <0.00%> (-2.08%) ⬇️
...er-live-common/src/featureFlags/defaultFeatures.ts 100.00% <ø> (ø)
libs/ledger-live-common/src/hw/actions/app.ts 10.55% <16.66%> (-0.17%) ⬇️
libs/ledgerjs/packages/hw-app-eth/src/errors.ts
...js/packages/hw-app-eth/src/modules/EIP712/index.ts
...js/packages/hw-app-eth/src/services/ledger/nfts.ts
libs/ledgerjs/packages/errors/src/helpers.ts
...ibs/ledgerjs/packages/hw-app-algorand/src/utils.ts
libs/ledgerjs/packages/errors/src/index.ts
libs/ledgerjs/packages/hw-app-xrp/src/Xrp.ts
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexandremgo alexandremgo merged commit 2802e2d into develop Oct 10, 2022
@alexandremgo alexandremgo deleted the feat/FAT-133 branch October 10, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants