Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/redelegate cosmos banner llm #1478

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

sarneijim
Copy link
Contributor

📝 Description

LLM - PTX - Crash when redelegating from Cosmos staking banner

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@sarneijim sarneijim requested a review from a team as a code owner October 5, 2022 18:01
@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 8:27AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 12, 2022 at 8:27AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 12, 2022 at 8:27AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 12, 2022 at 8:27AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2022

🦋 Changeset detected

Latest commit: 89ac63a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

@sarneijim

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 43.58% // Head: 46.14% // Increases project coverage by +2.55% 🎉

Coverage data is based on head (c736da9) compared to base (b34e551).
Patch has no changes to coverable lines.

❗ Current head c736da9 differs from pull request most recent head 89ac63a. Consider uploading reports for the commit 89ac63a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1478      +/-   ##
===========================================
+ Coverage    43.58%   46.14%   +2.55%     
===========================================
  Files          610      649      +39     
  Lines        25471    27981    +2510     
  Branches      6974     7512     +538     
===========================================
+ Hits         11102    12911    +1809     
- Misses       13242    13903     +661     
- Partials      1127     1167      +40     
Flag Coverage Δ
test 46.14% <ø> (+2.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmon/src/exchange/swap/hooks/useSwapTransaction.ts 47.36% <0.00%> (-2.64%) ⬇️
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
libs/ledger-live-common/src/apps/mock.ts 92.95% <0.00%> (-2.50%) ⬇️
libs/ledger-live-common/src/apps/runner.ts 52.83% <0.00%> (-2.08%) ⬇️
...edger-live-common/src/exchange/swap/utils/index.ts 63.52% <0.00%> (-1.54%) ⬇️
libs/ledger-live-common/src/hw/actions/app.ts 10.55% <0.00%> (-0.17%) ⬇️
...-live-common/src/exchange/swap/hooks/useToState.ts 100.00% <0.00%> (ø)
...ive-common/src/exchange/swap/hooks/useFromState.ts 96.29% <0.00%> (ø)
...common/src/exchange/swap/hooks/usePollKYCStatus.ts 100.00% <0.00%> (ø)
...common/src/exchange/swap/hooks/useProviderRates.ts 94.93% <0.00%> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sarneijim sarneijim requested a review from gre October 12, 2022 09:09
@ggilchrist-ledger
Copy link
Contributor

LGTM. Managed to redelegate with Ledger validator on Android

@sarneijim sarneijim merged commit df98cef into develop Oct 17, 2022
@sarneijim sarneijim deleted the bugfix/redelegate-cosmos-banner-llm branch October 17, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants