Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LIVE-2178 Prevent lock cases in USBTroubleShooting #1479

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

Improves the UX for the USB troubleshooting flow to prevent getting locked in it when we can't connect a device. It will now always include a way of escaping the flow and either returning to the onboarding flow or exiting if it was launched from the settings.

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-2178

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

There are videos and screenshots on the linked Jira task.

🚀 Expectations to reach

I'd say this is a best effort bugfix, we are removing blocking cases so it is genuinely a better UX.
Up to product and QA whether this is good enough to merge or not.

@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 9:12AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 6, 2022 at 9:12AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 6, 2022 at 9:12AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 6, 2022 at 9:12AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

🦋 Changeset detected

Latest commit: 465b8e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD translations Translation files have been touched labels Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 43.59% // Head: 43.58% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (09dc02c) compared to base (5c5795a).
Patch has no changes to coverable lines.

❗ Current head 09dc02c differs from pull request most recent head 465b8e4. Consider uploading reports for the commit 465b8e4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1479      +/-   ##
===========================================
- Coverage    43.59%   43.58%   -0.01%     
===========================================
  Files          610      610              
  Lines        25476    25476              
  Branches      6977     6974       -3     
===========================================
- Hits         11105    11104       -1     
- Misses       13243    14322    +1079     
+ Partials      1128       50    -1078     
Flag Coverage Δ
test 43.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ø)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ø)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ø)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ø)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ø)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ø)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ø)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ø)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ø)
... and 235 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@juan-cortes

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@juan-cortes juan-cortes merged commit 5a8f6a2 into develop Oct 14, 2022
@juan-cortes juan-cortes deleted the bugfix/LIVE-2178 branch October 14, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants