-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/LIVE-2178 Prevent lock cases in USBTroubleShooting #1479
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 465b8e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 43.59% // Head: 43.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1479 +/- ##
===========================================
- Coverage 43.59% 43.58% -0.01%
===========================================
Files 610 610
Lines 25476 25476
Branches 6977 6974 -3
===========================================
- Hits 11105 11104 -1
- Misses 13243 14322 +1079
+ Partials 1128 50 -1078
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📝 Description
Improves the UX for the USB troubleshooting flow to prevent getting locked in it when we can't connect a device. It will now always include a way of escaping the flow and either returning to the onboarding flow or exiting if it was launched from the settings.
❓ Context
ledger-live-desktop
https://ledgerhq.atlassian.net/browse/LIVE-2178
✅ Checklist
📸 Demo
There are videos and screenshots on the linked Jira task.
🚀 Expectations to reach
I'd say this is a best effort bugfix, we are removing blocking cases so it is genuinely a better UX.
Up to product and QA whether this is good enough to merge or not.