-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/LIVE-1955 Updated bad lottie animation for BLE LNX on LLM #1492
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2f69915 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 47.61% // Head: 43.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1492 +/- ##
===========================================
- Coverage 47.61% 43.01% -4.60%
===========================================
Files 687 609 -78
Lines 30260 25474 -4786
Branches 7923 6994 -929
===========================================
- Hits 14407 10958 -3449
+ Misses 14634 13383 -1251
+ Partials 1219 1133 -86
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f3f4fcd
to
2f69915
Compare
📝 Description
Currently in our production builds the animation for turning on and unlocking a device when we are on LLM with a Nano X over BLE shows a cable, and it shouldn't show a cable because it's BLE and BLE is wireless.
❓ Context
ledger-live-mobile
https://ledgerhq.atlassian.net/browse/LIVE-1955
✅ Checklist
📸 Demo
🚀 Expectations to reach
Make sure the animation no longer has a cable, Lottie debug tool also works.
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.