Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LIVE-1955 Updated bad lottie animation for BLE LNX on LLM #1492

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

Currently in our production builds the animation for turning on and unlocking a device when we are on LLM with a Nano X over BLE shows a cable, and it shouldn't show a cable because it's BLE and BLE is wireless.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-1955

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

image

🚀 Expectations to reach

Make sure the animation no longer has a cable, Lottie debug tool also works.

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 8:31AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 14, 2022 at 8:31AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 14, 2022 at 8:31AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 14, 2022 at 8:31AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

🦋 Changeset detected

Latest commit: 2f69915

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 47.61% // Head: 43.01% // Decreases project coverage by -4.59% ⚠️

Coverage data is based on head (fae7353) compared to base (7ed5027).
Patch has no changes to coverable lines.

❗ Current head fae7353 differs from pull request most recent head 2f69915. Consider uploading reports for the commit 2f69915 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1492      +/-   ##
===========================================
- Coverage    47.61%   43.01%   -4.60%     
===========================================
  Files          687      609      -78     
  Lines        30260    25474    -4786     
  Branches      7923     6994     -929     
===========================================
- Hits         14407    10958    -3449     
+ Misses       14634    13383    -1251     
+ Partials      1219     1133      -86     
Flag Coverage Δ
test 43.01% <ø> (-4.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/cryptoassets/data/esdt.js
...s/hw-app-btc/src/shouldUseTrustedInputForSegwit.ts
...s/packages/hw-app-eth/src/services/ledger/erc20.ts
libs/ledgerjs/packages/cryptoassets/data/trc10.js
libs/ledgerjs/packages/hw-app-btc/src/debug.ts
...s/hw-transport-mocker/src/openTransportReplayer.ts
libs/ledgerjs/packages/hw-app-btc/src/constants.ts
...edgerjs/packages/hw-app-btc/src/getTrustedInput.ts
.../ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts
...dgerjs/packages/hw-app-btc/src/newops/appClient.ts
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@alexandremgo

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@alexandremgo alexandremgo merged commit bdda4eb into develop Oct 14, 2022
@alexandremgo alexandremgo deleted the bugfix/LIVE-1955 branch October 14, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants