Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom manifest open button #1499

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Oct 6, 2022

πŸ“ Description

Moved the open button to the navbar to avoid it being hidden under the keyboard

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage It has been tested manually
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@Justkant Justkant self-assigned this Oct 6, 2022
@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 6, 2022 at 4:29PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 6, 2022 at 4:29PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 6, 2022 at 4:29PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 6, 2022 at 4:29PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

πŸ¦‹ Changeset detected

Latest commit: fffd152

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@JunichiSugiura JunichiSugiura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 43.59% // Head: 72.94% // Increases project coverage by +29.35% πŸŽ‰

Coverage data is based on head (8965fa9) compared to base (e4a98ad).
Patch has no changes to coverable lines.

❗ Current head 8965fa9 differs from pull request most recent head fffd152. Consider uploading reports for the commit fffd152 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1499       +/-   ##
============================================
+ Coverage    43.59%   72.94%   +29.35%     
============================================
  Files          610       62      -548     
  Lines        25476     4192    -21284     
  Branches      6974      830     -6144     
============================================
- Hits         11105     3058     -8047     
+ Misses       14321     1076    -13245     
- Partials        50       58        +8     
Flag Coverage Ξ”
test 72.94% <ΓΈ> (+29.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...r-live-common/src/families/algorand/api/indexer.ts
...dger-live-common/src/families/ethereum/exchange.ts
libs/ledger-live-common/src/account/support.ts
...mon/src/families/elrond/js-getTransactionStatus.ts
...live-common/src/families/osmosis/js-transaction.ts
...ve-common/src/families/polkadot/polkadot-crypto.ts
.../ledger-live-common/src/families/elrond/account.ts
...e-common/src/families/crypto_org/js-transaction.ts
...e-common/src/families/algorand/buildTransaction.ts
...ger-live-common/src/families/hedera/transaction.ts
... and 662 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@Justkant

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@Justkant Justkant merged commit 87fc5cc into develop Oct 6, 2022
@Justkant Justkant deleted the bugfix/custom-manifest-llm branch October 6, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants