[LLC] Add Dust Limit for bitcoin family #1513

lvndry · 2022-10-10T10:20:21Z

📝 Description

More info about what dusting is here.

Addition of a dust limit of 546 stats for bitcoin
Migration of AmountField from jsx -> tsx

❓ Context

Impacted projects: LLC
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-3373

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

vercel · 2022-10-10T10:20:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Oct 25, 2022 at 8:58AM (UTC)

3 Ignored Deployments

Name	Status	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)	Oct 25, 2022 at 8:58AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)	Oct 25, 2022 at 8:58AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)	Oct 25, 2022 at 8:58AM (UTC)

changeset-bot · 2022-10-10T10:20:26Z

🦋 Changeset detected

Latest commit: 0b4acb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
live-mobile	Patch
ledger-live-desktop	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2022-10-10T10:50:10Z

Codecov Report

Base: 47.57% // Head: 47.57% // No change to project coverage 👍

Coverage data is based on head (df8cbb8) compared to base (df8cbb8).
Patch has no changes to coverable lines.

❗ Current head df8cbb8 differs from pull request most recent head 0b4acb9. Consider uploading reports for the commit 0b4acb9 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1513   +/-   ##
========================================
  Coverage    47.57%   47.57%           
========================================
  Files          679      679           
  Lines        30143    30143           
  Branches      7900     7900           
========================================
  Hits         14340    14340           
  Misses       15738    15738           
  Partials        65       65

Flag	Coverage Δ
test	`47.57% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2022-10-10T11:15:15Z

@lvndry

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

libs/ledger-live-common/src/families/bitcoin/js-getTransactionStatus.ts

libs/ledger-live-common/src/transaction/common.ts

libs/ledgerjs/packages/types-live/src/transaction.ts

apps/ledger-live-desktop/release-notes.json

apps/ledger-live-desktop/src/renderer/components/RequestAmount.tsx

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx

apps/ledger-live-desktop/src/renderer/components/RequestAmount.tsx

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx

libs/ledger-live-common/src/families/bitcoin/wallet-btc/crypto/base.ts

libs/ledger-live-common/src/families/bitcoin/wallet-btc/crypto/bitcoin.ts

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx

error

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx

lambertkevin

changeset

lambertkevin

LGTM but don't forget your changeset !

ghost

Just need the translation key on LLM, the rest looks all good 👌

EDIT : also a changeset as mentioned by Kevin 👍 You can refer to this wiki page: https://github.com/LedgerHQ/ledger-live/wiki/Changesets

apps/ledger-live-desktop/static/i18n/en/app.json

apps/ledger-live-desktop/src/renderer/reducers/settings.js

apps/ledger-live-mobile/src/screens/SendFunds/03a-AmountCoin.tsx

* add dust limit error for bitcoin * uncomment bridge tests * dust limit as constant * unused import * correct config files * lockfile * error not undefined * typing * fix typo * improve typing * LLM dust limit * changeset * disable button if dust limit Co-authored-by: lvndry <[email protected]>

lvndry self-assigned this Oct 10, 2022

github-actions bot added common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched labels Oct 10, 2022

vercel bot deployed to Preview – live-common-tools October 10, 2022 10:23 View deployment

lvndry force-pushed the feat/live-3373-btc-dust-limit branch from e71a5a5 to cec6a54 Compare October 10, 2022 10:27

vercel bot deployed to Preview – live-common-tools October 10, 2022 10:30 View deployment

vercel bot deployed to Preview – live-common-tools October 10, 2022 10:33 View deployment

vercel bot deployed to Preview – live-common-tools October 10, 2022 11:50 View deployment

github-actions bot removed the mobile Has changes in LLM label Oct 10, 2022

vercel bot deployed to Preview – live-common-tools October 10, 2022 11:52 View deployment

henri-ly suggested changes Oct 10, 2022

View reviewed changes

hedi-edelbloute previously approved these changes Oct 10, 2022

View reviewed changes

apps/ledger-live-desktop/src/renderer/components/RequestAmount.tsx Outdated Show resolved Hide resolved

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx Show resolved Hide resolved

hedi-edelbloute reviewed Oct 10, 2022

View reviewed changes

libs/ledger-live-common/src/families/bitcoin/wallet-btc/crypto/base.ts Outdated Show resolved Hide resolved

libs/ledger-live-common/src/families/bitcoin/wallet-btc/crypto/bitcoin.ts Show resolved Hide resolved

hedi-edelbloute reviewed Oct 10, 2022

View reviewed changes

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx Show resolved Hide resolved

lambertkevin requested changes Oct 10, 2022

View reviewed changes

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx Outdated Show resolved Hide resolved

apps/ledger-live-desktop/src/renderer/modals/Send/fields/AmountField.tsx Outdated Show resolved Hide resolved

lvndry force-pushed the feat/live-3373-btc-dust-limit branch from 88864b9 to 184135c Compare October 10, 2022 14:52

vercel bot deployed to Preview – live-common-tools October 10, 2022 14:54 View deployment

lvndry requested review from hedi-edelbloute, henri-ly and lambertkevin October 10, 2022 15:01

vercel bot deployed to Preview – live-common-tools October 10, 2022 15:01 View deployment

vercel bot deployed to Preview – live-common-tools October 10, 2022 15:57 View deployment

henri-ly approved these changes Oct 12, 2022

View reviewed changes

lambertkevin reviewed Oct 13, 2022

View reviewed changes

lambertkevin self-requested a review October 13, 2022 13:44

lambertkevin approved these changes Oct 13, 2022

View reviewed changes

ghost suggested changes Oct 13, 2022

View reviewed changes

apps/ledger-live-desktop/static/i18n/en/app.json Show resolved Hide resolved

apps/ledger-live-desktop/src/renderer/reducers/settings.js Show resolved Hide resolved

github-actions bot added the mobile Has changes in LLM label Oct 18, 2022

vercel bot deployed to Preview – live-common-tools October 18, 2022 11:23 View deployment

vercel bot deployed to Preview – live-common-tools October 18, 2022 11:40 View deployment

lvndry requested a review from a user October 18, 2022 11:44

ghost approved these changes Oct 24, 2022

View reviewed changes

apps/ledger-live-mobile/src/screens/SendFunds/03a-AmountCoin.tsx Show resolved Hide resolved

lvndry added 13 commits October 25, 2022 10:55

add dust limit error for bitcoin

aef4b11

uncomment bridge tests

6e8af8d

dust limit as constant

e15ff49

unused import

0beb909

correct config files

cc5a1e9

lockfile

efb82e1

error not undefined

8a4df5d

typing

c1441c4

fix typo

08675f0

improve typing

5574aa8

LLM dust limit

a65384d

changeset

54a381f

disable button if dust limit

0b4acb9

lvndry force-pushed the feat/live-3373-btc-dust-limit branch from eced21c to 0b4acb9 Compare October 25, 2022 08:56

vercel bot deployed to Preview – live-common-tools October 25, 2022 08:58 View deployment

ghost merged commit ffc377d into develop Oct 26, 2022

ghost deleted the feat/live-3373-btc-dust-limit branch October 26, 2022 11:33

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLC] Add Dust Limit for bitcoin family #1513

[LLC] Add Dust Limit for bitcoin family #1513

lvndry commented Oct 10, 2022 •

edited

Loading

vercel bot commented Oct 10, 2022 •

edited

Loading

changeset-bot bot commented Oct 10, 2022 •

edited

Loading

codecov bot commented Oct 10, 2022 •

edited

Loading

github-actions bot commented Oct 10, 2022 •

edited

Loading

lambertkevin left a comment •

edited

Loading

lambertkevin left a comment

ghost left a comment •

edited by ghost

Loading

[LLC] Add Dust Limit for bitcoin family #1513

[LLC] Add Dust Limit for bitcoin family #1513

Conversation

lvndry commented Oct 10, 2022 • edited Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

vercel bot commented Oct 10, 2022 • edited Loading

changeset-bot bot commented Oct 10, 2022 • edited Loading

🦋 Changeset detected

codecov bot commented Oct 10, 2022 • edited Loading

Codecov Report

github-actions bot commented Oct 10, 2022 • edited Loading

lambertkevin left a comment • edited Loading

Choose a reason for hiding this comment

lambertkevin left a comment

Choose a reason for hiding this comment

ghost left a comment • edited by ghost Loading

Choose a reason for hiding this comment

lvndry commented Oct 10, 2022 •

edited

Loading

vercel bot commented Oct 10, 2022 •

edited

Loading

changeset-bot bot commented Oct 10, 2022 •

edited

Loading

codecov bot commented Oct 10, 2022 •

edited

Loading

github-actions bot commented Oct 10, 2022 •

edited

Loading

lambertkevin left a comment •

edited

Loading

ghost left a comment •

edited by ghost

Loading