Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAT-128 FAT-120 FAT-121 Prompt language change after live language change #1531

Merged

Conversation

grsoares21
Copy link
Contributor

📝 Description

This PR adds a few prompts suggesting to the user to change their device language. The prompts appear when:

  • The user changes Live language and the target language is available for the last seen device
  • The user updates the devices to a firmware that supports the current Live language
  • The user had a non-English language installed on their device before a a firmware update (the language gets automatically reinstalled since it's deleted by the update)

❓ Context

FAT-128
FAT-121
FAT-120

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Prompt after Live language change:
prompt-after-live-language-change
Prompt when Live's language first becomes available for the device:
prompt-after-live-update
Reinstall language after firmware update:
reinstall-after-live-update

🚀 Expectations to reach

…o feat/FAT-126-change-nano-language-from-the-manager
@grsoares21 grsoares21 requested a review from a team as a code owner October 11, 2022 10:12
@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 10:12AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 11, 2022 at 10:12AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 11, 2022 at 10:12AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 11, 2022 at 10:12AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

🦋 Changeset detected

Latest commit: bcea8cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD screenshots Screenshots have been updated translations Translation files have been touched labels Oct 11, 2022
@grsoares21 grsoares21 closed this Oct 11, 2022
@github-actions
Copy link

github-actions bot commented Oct 11, 2022

@grsoares21

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@grsoares21 grsoares21 deleted the feat/FAT-128-prompt-language-change-after-live-language-change branch October 11, 2022 11:41
@grsoares21 grsoares21 restored the feat/FAT-128-prompt-language-change-after-live-language-change branch October 11, 2022 11:43
@grsoares21 grsoares21 reopened this Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 43.57% // Head: 48.07% // Increases project coverage by +4.50% 🎉

Coverage data is based on head (693d323) compared to base (50fc0cc).
Patch has no changes to coverable lines.

❗ Current head 693d323 differs from pull request most recent head bcea8cd. Consider uploading reports for the commit bcea8cd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1531      +/-   ##
===========================================
+ Coverage    43.57%   48.07%   +4.50%     
===========================================
  Files          610      688      +78     
  Lines        25489    30275    +4786     
  Branches      6982     7916     +934     
===========================================
+ Hits         11106    14556    +3450     
- Misses       13255    14505    +1250     
- Partials      1128     1214      +86     
Flag Coverage Δ
test 48.07% <ø> (+4.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bs/ledgerjs/packages/hw-app-btc/src/buffertools.ts 70.73% <0.00%> (ø)
...edgerjs/packages/hw-app-btc/src/signTransaction.ts 77.77% <0.00%> (ø)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ø)
...dgerjs/packages/cryptoassets/data/polygon-erc20.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-tezos/src/Tezos.ts 11.34% <0.00%> (ø)
...gerjs/packages/hw-app-btc/src/createTransaction.ts 81.67% <0.00%> (ø)
libs/ledgerjs/packages/devices/src/index.ts 63.15% <0.00%> (ø)
...hw-transport-mocker/src/createTransportRecorder.ts 13.04% <0.00%> (ø)
...js/packages/hw-app-btc/src/newops/psbtFinalizer.ts 78.57% <0.00%> (ø)
.../ledgerjs/packages/hw-app-btc/src/newops/policy.ts 91.66% <0.00%> (ø)
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@grsoares21 grsoares21 merged commit 52ecc41 into develop Oct 12, 2022
@grsoares21 grsoares21 deleted the feat/FAT-128-prompt-language-change-after-live-language-change branch October 12, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants