Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› bugfix(Swap): LLM - Swap buttons not available on Currency and account screens #1533

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Oct 11, 2022

πŸ“ Description

Swap buttons not available on Currency and account screens (Quick Actions)

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): LIVE-4178

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 13, 2022 at 9:19AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 13, 2022 at 9:19AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 9:19AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 9:19AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

πŸ¦‹ Changeset detected

Latest commit: ee91bd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 47.61% // Head: 47.61% // No change to project coverage πŸ‘

Coverage data is based on head (4251478) compared to base (2c3d6b5).
Patch has no changes to coverable lines.

❗ Current head 4251478 differs from pull request most recent head ee91bd6. Consider uploading reports for the commit ee91bd6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1533   +/-   ##
========================================
  Coverage    47.61%   47.61%           
========================================
  Files          687      687           
  Lines        30258    30258           
  Branches      7912     7912           
========================================
  Hits         14407    14407           
  Misses       14632    14632           
  Partials      1219     1219           
Flag Coverage Ξ”
test 47.61% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@ggilchrist-ledger ggilchrist-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button appears correctly now. I've noticed that non-default BTC accounts and non-BTC currecies aren't automatically selected as the 'From' currency when navigating to swap, but @mcayuelas-ledger tells me this is known and being dealt with in a separate Hub ticket

@mcayuelas-ledger mcayuelas-ledger merged commit 107e9cf into develop Oct 17, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/LIVE-4178-Swap-buttons-not-available branch October 17, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants