-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LIVE-3802 Receive stake banner first #1539
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 56f9463 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 43.37% // Head: 45.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1539 +/- ##
===========================================
+ Coverage 43.37% 45.68% +2.31%
===========================================
Files 613 648 +35
Lines 25648 27837 +2189
Branches 7046 7482 +436
===========================================
+ Hits 11125 12718 +1593
- Misses 13396 15037 +1641
+ Partials 1127 82 -1045
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
5487121
to
2cbde68
Compare
apps/ledger-live-desktop/src/renderer/modals/Receive/steps/StepReceiveStakingFlow.tsx
Outdated
Show resolved
Hide resolved
There are two issues I can see.
Screen.Recording.2022-10-21.at.17.10.32.mov
|
apps/ledger-live-desktop/src/renderer/modals/Receive/steps/StepReceiveStakingFlow.tsx
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/modals/Receive/steps/StepReceiveStakingFlow.tsx
Outdated
Show resolved
Hide resolved
Changed |
π Description
Receive stake banner implementation
β Context
Data tracking plan https://ledgerhq.atlassian.net/wiki/spaces/PTX/pages/3863248902/Receive+-+Data+Tracking+Plan
β Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.