support: eslint rule on live-common import path #1569
Conversation
Having the "/lib" inside the path when importing from "@ledgerhq/live-common" can results in bugs This eslint rule throw an error on the pattern "@ledgerhq/live-common/lib/*"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ec39185 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 43.01% // Head: 74.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1569 +/- ##
============================================
+ Coverage 43.01% 74.26% +31.24%
============================================
Files 609 56 -553
Lines 25472 2922 -22550
Branches 6978 566 -6412
============================================
- Hits 10957 2170 -8787
+ Misses 13382 746 -12636
+ Partials 1133 6 -1127
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
📝 Description
Having the
/libinside the path when importing from"@ledgerhq/live-common"can results in bugsThis eslint rule, using the rule no-restricted-imports throws an error on the pattern `"@ledgerhq/live-common/lib/*"``
❓ Context
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.