Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-4186 - LLM analytics for reborn update #1577

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Oct 13, 2022

📝 Description

LLM analytics for reborn update.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-4186

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 3:41PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 13, 2022 at 3:41PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 3:41PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 3:41PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: 925398b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 44.51% // Head: 47.52% // Increases project coverage by +3.00% 🎉

Coverage data is based on head (925398b) compared to base (7593158).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1577      +/-   ##
===========================================
+ Coverage    44.51%   47.52%   +3.00%     
===========================================
  Files          622      685      +63     
  Lines        26640    30038    +3398     
  Branches      7213     7876     +663     
===========================================
+ Hits         11860    14275    +2415     
- Misses       13635    14560     +925     
- Partials      1145     1203      +58     
Flag Coverage Δ
test 47.52% <ø> (+3.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ø)
...ckages/hw-app-btc/tests/newops/integrationtools.ts 92.03% <0.00%> (ø)
...s/packages/hw-app-btc/src/newops/clientCommands.ts 10.45% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-xrp/src/Xrp.ts 89.09% <0.00%> (ø)
...s/hw-transport-mocker/src/openTransportReplayer.ts 63.63% <0.00%> (ø)
...s/packages/hw-app-btc/src/getTrustedInputBIP143.ts 78.94% <0.00%> (ø)
...hw-transport-mocker/src/createTransportRecorder.ts 13.04% <0.00%> (ø)
...gerjs/packages/hw-app-btc/src/createTransaction.ts 81.67% <0.00%> (ø)
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 13, 2022

@LFBarreto

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ThomasLaforge ThomasLaforge merged commit 9259d6c into develop Oct 14, 2022
@ThomasLaforge ThomasLaforge deleted the bugfix/LIVE-4186 branch October 14, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants