Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed React-Native-Fingerprints-Scanner with React-native-biometrics #1639

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Removed React-Native-Fingerprints-Scanner with React-native-biometrics #1639

merged 5 commits into from
Oct 21, 2022

Conversation

mle-gall
Copy link
Contributor

@mle-gall mle-gall commented Oct 20, 2022 •
edited
Loading

πŸ“ Description

Replaced the legacy and unmainained lib React-Native-Fingerprints-Scanner with new and fancy React-native-biometrics

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): LIVE-4326

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

N/A

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 21, 2022 at 8:26AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 21, 2022 at 8:26AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 21, 2022 at 8:26AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 21, 2022 at 8:26AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022 •
edited
Loading

πŸ¦‹ Changeset detected

Latest commit: 45e3e20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM ui Has changes in the design system library labels Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Base: 45.41% // Head: 43.22% // Decreases project coverage by -2.19% ⚠️

Coverage data is based on head (876b9eb) compared to base (0942e30).
Patch has no changes to coverable lines.

❗ Current head 876b9eb differs from pull request most recent head 45e3e20. Consider uploading reports for the commit 45e3e20 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1639      +/-   ##
===========================================
- Coverage    45.41%   43.22%   -2.20%     
===========================================
  Files          646      611      -35     
  Lines        27728    25539    -2189     
  Branches      7475     6992     -483     
===========================================
- Hits         12594    11040    -1554     
- Misses       14001    14448     +447     
+ Partials      1133       51    -1082
Flag Coverage Ξ”
test 43.22% <ΓΈ> (-2.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/env.ts 74.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ΓΈ)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ΓΈ)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ΓΈ)
libs/ledger-live-common/src/apps/logic.ts 89.71% <0.00%> (ΓΈ)
... and 272 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 20, 2022 •
edited
Loading

@mlegall-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

valpinkman
valpinkman reviewed Oct 21, 2022
View reviewed changes
apps/ledger-live-mobile/package.json
"react-native-ble-plx": "2.0.3",
"react-native-codegen": "^0.0.7",
"react-native-config": "1.4.4",
"react-native-easy-markdown": "^2.0.0",
"react-native-extra-dimensions-android": "^1.2.5",
"react-native-fast-crypto": "^2.2.0",
"react-native-fast-image": "^8.5.11",
"react-native-fingerprint-scanner": "git+https://github.com/hieuvp/react-native-fingerprint-scanner.git#f1d136f605412d58e4de9e7e155d6f818ba24731",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank god we remove this atrocity XD

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit sad that we traded 1 unmaintained library for another :(
Last publish: 2 years ago 😒

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not https://github.com/SelfLender/react-native-biometrics latest release is from 2 month ago

valpinkman
valpinkman approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks for unlocking everyone ;)

elbywan
elbywan approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@elbywan elbywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Œ

@mle-gall mle-gall merged commit 1ea8be2 into develop Oct 21, 2022
@mle-gall mle-gall deleted the bugfix/LIVE-4326/replacedBiometricsLibrary branch October 21, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valpinkman valpinkman valpinkman approved these changes

@lambertkevin lambertkevin lambertkevin left review comments

@Justkant Justkant Justkant approved these changes

@elbywan elbywan elbywan approved these changes

@hedi-edelbloute hedi-edelbloute hedi-edelbloute approved these changes

@ofreyssinet-ledger ofreyssinet-ledger ofreyssinet-ledger approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@mle-gall mle-gall

Labels
mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mle-gall @valpinkman @Justkant @elbywan @hedi-edelbloute @lambertkevin @ofreyssinet-ledger @mcayuelas-ledger