-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAT-569 - Fix infinite loop in ChangeDeviceLanguagePromptDrawer #1654
FAT-569 - Fix infinite loop in ChangeDeviceLanguagePromptDrawer #1654
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2fd8332 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 0.00% // Head: 43.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1654 +/- ##
============================================
+ Coverage 0 43.23% +43.23%
============================================
Files 0 611 +611
Lines 0 25539 +25539
Branches 0 7015 +7015
============================================
+ Hits 0 11041 +11041
- Misses 0 13370 +13370
- Partials 0 1128 +1128
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* Fix infinite loop in ChangeDeviceLanguagePromptDrawer * changeset * Memoize ChangeDeviceLanguageAction & ChangeDeviceLanguagePromptDrawer
* Fix infinite loop in ChangeDeviceLanguagePromptDrawer * changeset * Memoize ChangeDeviceLanguageAction & ChangeDeviceLanguagePromptDrawer
* Fix infinite loop in ChangeDeviceLanguagePromptDrawer * changeset * Memoize ChangeDeviceLanguageAction & ChangeDeviceLanguagePromptDrawer
* Fix infinite loop in ChangeDeviceLanguagePromptDrawer * changeset * Memoize ChangeDeviceLanguageAction & ChangeDeviceLanguagePromptDrawer
📝 Description
Steps to Reproduce:
Enable the device localization FF
connect a device that supports localization so its registered in LLD as the “last seen” device. (Go to the manager for instance)
Go to settings, change the language to a one supported for device localization
When prompted, choose to install the language on the device.
Deny on the device or do any action that would trigger an error in the device action
Expected behavior:
LLD doesn’t go into an infinite loop, sending thousands of error events until the drawer is closed.
Actual behavior:
LLD goes in into an infinite loop, sending thousands of error events until the drawer is closed
❓ Context
ledger-live-desktop
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.